From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Re: Font-lock in COMINT modes Date: Thu, 07 Dec 2006 11:00:30 -0700 Message-ID: References: NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1165514496 19277 80.91.229.10 (7 Dec 2006 18:01:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 7 Dec 2006 18:01:36 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 07 19:01:33 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GsNYa-0000Bg-Uk for ged-emacs-devel@m.gmane.org; Thu, 07 Dec 2006 19:01:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsNYa-0007X9-IY for ged-emacs-devel@m.gmane.org; Thu, 07 Dec 2006 13:01:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GsNYL-0007Wt-NE for emacs-devel@gnu.org; Thu, 07 Dec 2006 13:01:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GsNYK-0007WT-7v for emacs-devel@gnu.org; Thu, 07 Dec 2006 13:01:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsNYK-0007WQ-2F for emacs-devel@gnu.org; Thu, 07 Dec 2006 13:01:00 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GsNYJ-0004JU-69 for emacs-devel@gnu.org; Thu, 07 Dec 2006 13:00:59 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GsNY5-00087Q-EM for emacs-devel@gnu.org; Thu, 07 Dec 2006 19:00:45 +0100 Original-Received: from turtle.as.arizona.edu ([128.196.208.207]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 07 Dec 2006 19:00:45 +0100 Original-Received: from jdsmith by turtle.as.arizona.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 07 Dec 2006 19:00:45 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 38 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: turtle.as.arizona.edu User-Agent: Pan/0.14.2.91 (As She Crawled Across the Table) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63423 Archived-At: Here is the change which altered the default behavior in comint modes. ---------------------------- revision 1.348 date: 2006-09-28 19:09:19 +0000; author: rms; state: Exp; lines: +4 -1 (comint-mode): Bind font-lock-defaults non-nil. ---------------------------- If font-lock-defaults is left nil instead of being explicitly set to '(nil) as it now is, keywords-only is implicitly true, and strings and comments are not fontified by default. With this change, strings and comments are fontified by default in all comint modes (unless they set font-lock-defaults on their own). This patch would restore the earlier behavior. Since I'm uncertain whether '(nil) was intended to nullify keywords-only, I'm not sure if the patch is appropriate (i.e. is '(nil t) practically any different from nil). *** comint.el 28 Nov 2006 11:25:56 -0700 1.350 --- comint.el 07 Dec 2006 10:54:48 -0700 *************** *** 653,659 **** (make-local-variable 'comint-accum-marker) (setq comint-accum-marker (make-marker)) (make-local-variable 'font-lock-defaults) ! (setq font-lock-defaults '(nil)) (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This behavior is not useful in comint buffers, and is annoying (set (make-local-variable 'next-line-add-newlines) nil)) --- 653,659 ---- (make-local-variable 'comint-accum-marker) (setq comint-accum-marker (make-marker)) (make-local-variable 'font-lock-defaults) ! (setq font-lock-defaults '(nil t)) (add-hook 'change-major-mode-hook 'font-lock-defontify nil t) ;; This behavior is not useful in comint buffers, and is annoying (set (make-local-variable 'next-line-add-newlines) nil))