From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Re: vc-annotate error, PATCH Date: Mon, 10 Apr 2006 15:59:44 -0700 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1144710026 9170 80.91.229.2 (10 Apr 2006 23:00:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Apr 2006 23:00:26 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 11 01:00:24 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FT5Mr-0002dL-TR for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 01:00:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT5Mr-0007Z9-Gq for ged-emacs-devel@m.gmane.org; Mon, 10 Apr 2006 19:00:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FT5Mf-0007Yu-2J for emacs-devel@gnu.org; Mon, 10 Apr 2006 19:00:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FT5Md-0007Yg-H3 for emacs-devel@gnu.org; Mon, 10 Apr 2006 19:00:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT5Md-0007Yd-Eb for emacs-devel@gnu.org; Mon, 10 Apr 2006 19:00:07 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FT5RM-0001d0-Pi for emacs-devel@gnu.org; Mon, 10 Apr 2006 19:05:01 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FT5MT-0002YN-KW for emacs-devel@gnu.org; Tue, 11 Apr 2006 00:59:57 +0200 Original-Received: from turtle.as.arizona.edu ([128.196.208.207]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Apr 2006 00:59:57 +0200 Original-Received: from jdsmith by turtle.as.arizona.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Apr 2006 00:59:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 20 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: turtle.as.arizona.edu User-Agent: Pan/0.14.2.91 (As She Crawled Across the Table) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52627 Archived-At: On Mon, 10 Apr 2006 18:27:46 -0400, Stefan Monnier wrote: >> I looked into this further, and it turns out the ordering was correct, >> but the `temp-buffer-show-function' was getting called before the >> local variables were set, at the end of `with-output-to-temp-buffer'. >> Since this in turns calls the auto-scaling display code, which >> requires the local variables to be set, it fails. > [...] >> Below is a patch which does all this. Any objections to installing >> it? Give it a try on a really old file, like subr.el. > > Thanks. The bug-fix part of the patch looks fine to me, thank you for > tracking it down and please install it. > I have no opinion on the colormap part of the code. No problem. Unless anyone has any objections in the next day or so to the changes in colormap and default display mode, I'll install. JD