From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: vc-annotate error Date: Fri, 07 Apr 2006 16:28:16 -0700 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1144452540 22301 80.91.229.2 (7 Apr 2006 23:29:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 7 Apr 2006 23:29:00 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 08 01:28:58 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FS0Nq-0002Wu-2i for ged-emacs-devel@m.gmane.org; Sat, 08 Apr 2006 01:28:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FS0Np-0004I3-Jz for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2006 19:28:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FS0Nb-0004Hn-Uk for emacs-devel@gnu.org; Fri, 07 Apr 2006 19:28:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FS0Na-0004HS-Gx for emacs-devel@gnu.org; Fri, 07 Apr 2006 19:28:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FS0Na-0004HP-Cy for emacs-devel@gnu.org; Fri, 07 Apr 2006 19:28:38 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FS0Re-0000wd-CQ for emacs-devel@gnu.org; Fri, 07 Apr 2006 19:32:50 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FS0NM-0002TS-LR for emacs-devel@gnu.org; Sat, 08 Apr 2006 01:28:24 +0200 Original-Received: from turtle.as.arizona.edu ([128.196.208.207]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Apr 2006 01:28:24 +0200 Original-Received: from jdsmith by turtle.as.arizona.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Apr 2006 01:28:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 36 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: turtle.as.arizona.edu User-Agent: Pan/0.14.2.91 (As She Crawled Across the Table) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52521 Archived-At: vc-annotate is giving me a similar error as was reported earlier for vc.el revision 1.408: (file-error "Cannot open load file" "vc-nil") This occurs because I have specified a default annotate mode of 'fullscale, and the `vc-annotate-display-autoscale' function still relies on the variable `vc-annotate-backend' to call the appropriate backend time functions I wrote years ago. This was formerly a global variable, but Stefan's changes to `vc-annotate' circa 1.408 made it buffer local: (with-current-buffer temp-buffer-name (set (make-local-variable 'vc-annotate-backend) (vc-backend file)) (set (make-local-variable 'vc-annotate-parent-file) file) (set (make-local-variable 'vc-annotate-parent-rev) rev) (set (make-local-variable 'vc-annotate-parent-display-mode) display-mode)) For whatever reason, these are not currently being set in the annotate output buffer, which breaks the auto-scaling annotation display, since it doesn't know the backend to use. I haven't figured out how the buffer-local variables are being lost. Other annotate display modes don't have backend-specific functions, so they continue to work. By the way, should we make 'fullscale the default display mode? Rather than scaling colors based on a fixed time window (1 year I believe is the current default), it auto-scales to ensure the oldest and newest colors both are used, to match the dynamic range of annotation dates in the file to the available number of display colors. Currently, files less than a year old will be displayed entirely in one color. JD