unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "T.V Raman" <raman@google.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Matthew Newton <matt@knosis.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Add `advice-remove-all`
Date: Wed, 04 Sep 2019 17:14:42 -0700	[thread overview]
Message-ID: <p91zhjjppjh.fsf@google.com> (raw)
In-Reply-To: <jwv5zm7q5ot.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 04 Sep 2019 14:30:49 -0400")

Using the original advice.el, you could assign an advice a "name";
redefining that named advice then got you the new behavior.

In that environment, and perhaps until emacs 25, doing describe-function
told you a function was advised, more importantly, you  also got a
button that you could click in the help buffer that showed the doc
string for that advice 
-- 



  reply	other threads:[~2019-09-05  0:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 16:59 [PATCH] Add `advice-remove-all` Matthew Newton
2019-09-04 18:30 ` Stefan Monnier
2019-09-05  0:14   ` T.V Raman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-04-27  3:23 Tianxiang Xiong
2017-04-27 12:52 ` Stefan Monnier
2017-05-01 13:26   ` Marcin Borkowski
2017-05-01 17:21     ` Stefan Monnier
2017-05-02  5:31       ` Marcin Borkowski
2017-05-02 13:47         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p91zhjjppjh.fsf@google.com \
    --to=raman@google.com \
    --cc=emacs-devel@gnu.org \
    --cc=matt@knosis.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).