From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Async rebuild package-quickstart after packages update? was Re: 28.0.50; Proposal: slightly more efficient package-quickstart.el Date: Thu, 05 Aug 2021 07:29:30 -0700 Message-ID: References: <24842.41537.969310.87574@retriever.mtv.corp.google.com> <83tuk4jusd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, arthur.miller@live.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 05 16:30:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBeO4-00031J-9S for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Aug 2021 16:30:20 +0200 Original-Received: from localhost ([::1]:47972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBeO2-0007sM-Qa for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Aug 2021 10:30:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBeNN-0007BS-Ir for emacs-devel@gnu.org; Thu, 05 Aug 2021 10:29:37 -0400 Original-Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:50840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBeNL-0006JQ-0b for emacs-devel@gnu.org; Thu, 05 Aug 2021 10:29:37 -0400 Original-Received: by mail-pj1-x102c.google.com with SMTP id l19so9300540pjz.0 for ; Thu, 05 Aug 2021 07:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=zVVRyCNlfrsXsBgUw8GLOCcwDYP8HbM5b10ehz+TAcI=; b=QCUPOfCU1CMgP2p+ZytljgF8iaG8k+b1WyqiwfPunowsdaVwOrCmi6yueAohh1VFHY KmUGMgliUNEbXjM1/lqzaSkfA0Ei9C178ANkVfTTkLgsmN6i3DlZ+rOVEcOjztgNBBn2 i2Q4rRUF27RVj+HniE+LbsRaunXIq93TYregWW/ny4yp3ENIHftRMEEzrO0bWMahe12m ZtxFCSFsL42enlK2dxpsKQ0qw1h5ZvEiL0sd2ThQFUbPN9Gr8u9uTXJOGS66efNldRaz roTt+RzkOEWNZlEUJPhnBZwnYyfMVyVSnKBGTgzH5CP4hO/sjBpqikpQW/6EoYlFtfAT U2qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zVVRyCNlfrsXsBgUw8GLOCcwDYP8HbM5b10ehz+TAcI=; b=S7qfTm2fiiLejW3PsZbVYnPLhqy9OeFbzIPSEZPmej7rdwI2ypp6uPkahwfJW/K70O wqbwSB8WK+MXV9Wkzlt+rWMEiKJIW+gbAaze8wKEupVK6I1I+kQ9vGSry5NPMiT7+YAY 64Jha9MGdTleRzP0eqZGnvmBO2P9/vNTaQtMKC7PutQtFsmAO1EAyiYccq315333igWn PE49KASqtloQqehTSqDn9smKhv/thPFN4Eul0T6m5Sqs0ctXuyhWqd0XkJvkXt1y7v+a Bcd08pb6j2IvMP8qQBWQbxCHJlDv8Fz6vxM5umBL7XTDwsA4Dh5GBCwTIV13lGjPR7Ng TpqQ== X-Gm-Message-State: AOAM533mubcTQnX9NToe+XUkMDpDelkW2csE/dE3gZfeVVGBQRhYwhV3 BcaAvwa1j4tiGojIFkloaqojW+zWmz8PoYew X-Google-Smtp-Source: ABdhPJz6I7Qv8pX8fK5+1mSpC8dJBjga81/G0PjAGY3idKp30L+ZzrZxaoOaauLGaHh0VjHLIhcEkQ== X-Received: by 2002:a17:902:ab98:b029:12b:acc0:e18c with SMTP id f24-20020a170902ab98b029012bacc0e18cmr4222971plr.10.1628173772959; Thu, 05 Aug 2021 07:29:32 -0700 (PDT) Original-Received: from raman-glaptop (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id c24sm8398348pgj.11.2021.08.05.07.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 07:29:31 -0700 (PDT) In-Reply-To: <83tuk4jusd.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Aug 2021 09:00:02 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=raman@google.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272090 Archived-At: Eli Zaretskii writes: Here is the updated patch: git diff master diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 37dcbe36c8..4e59623cbc 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4138,7 +4138,12 @@ package--quickstart-maybe-refresh (if package-quickstart ;; FIXME: Delay refresh in case we're installing/deleting ;; several packages! - (package-quickstart-refresh) + (start-process + "quickstart" " *quickstart*" + (expand-file-name invocation-name invocation-directory) + "-batch" "-q" + "-l" "package" + "-f" "package-quickstart-refresh") (delete-file (concat package-quickstart-file "c")) (delete-file package-quickstart-file))) =20 >> From: "T.V Raman" >> Cc: arthur.miller@live.com, emacs-devel@gnu.org >> Date: Wed, 04 Aug 2021 17:22:23 -0700 >>=20 >> Here is a simple patch that rebuilds package-quickstart-file in a >> separate emacs process: > > Thanks. I have one minor comment: > >> - (package-quickstart-refresh) >> + (start-process >> + "quickstart" "*quickstart*" "emacs" >> + "-batch" "-q" >> + "-l" "package" >> + "-f" "package-quickstart-refresh") > > The 3rd argument of start-process should use > > (expand-file-name invocation-name invocation-directory) > > instead of the literal "emacs", so that it invokes the same Emacs > binary as the one in which the command runs. > --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =817=A94 Id: kg:/m/0285kf1 =950=DC8