From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 Date: Sun, 13 Sep 2020 09:43:13 -0700 Message-ID: References: <24414.11044.596033.388237@google.com> <87363llnou.fsf@gnus.org> <87v9ghir7o.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34584"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 18:44:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHV6j-0008uk-Ms for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 18:44:05 +0200 Original-Received: from localhost ([::1]:40106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHV6i-0003Xw-OO for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 12:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHV61-00032q-3w for emacs-devel@gnu.org; Sun, 13 Sep 2020 12:43:21 -0400 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:51005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHV5z-0005t5-3n for emacs-devel@gnu.org; Sun, 13 Sep 2020 12:43:20 -0400 Original-Received: by mail-pj1-x1035.google.com with SMTP id fa1so4246053pjb.0 for ; Sun, 13 Sep 2020 09:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=NGWUBNEB0gIeW9h3k1zs+lmNKgESmlcjD4/BuIBbfyA=; b=jOIzVJSDi96vDEogkNBtwPd7wPfsCbcgUCFPndqIbFSJFUZnIIyP0hWCJ/6rzdNy54 EjxwPiXDQdh8+G8LyHQ09R8+uEMYGRgfBqEVjkiHJvlfPtPoCcoyY5z3ekI+4wJP/yQM DceSUr9P52eo9qD/3A7h56KMgR0OhoQBv6H7gK8DbUYoXzoa0jc7BUdjnNyU8ePjy3Ey kdBHX4hwU9/eTh+LB3GZ+0W3rtR4ri0hUPitYvR7VGw9bg3CZCxGB25Csou32TLuGjHH 9CZJVDuZQexttFwXBxfvbMlhhOPOQg+cJrPiGRYolVkqsaxd5iiwp2khEg6boQaAnpdF 1cuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NGWUBNEB0gIeW9h3k1zs+lmNKgESmlcjD4/BuIBbfyA=; b=KcA5B0m2HKQMb3ICUqPgqLNXQRCwNJi4FuPeqd3yOVquKu5i2EBzbW29Fy+FTdXC5J pYIKief7pKHHpHHMdy8bUdgZOoVwl1VRWypPaADgRI/kTrnd4WtMh5JwiHINozWMte2R D9izCv84JseZjEs4k9EWntYier1x1EOydyhuxXIF3kx0J+QaSk1JTxuVUVQ71XEozj2O 1dT9uRvcN8pcMIxIIJ/U0gatLzfv+ZFWil6xt00se5d3xZkgDsIoRz64gOGjwyjVzgKc mCj2WPkfqDMLUuZHPFolXjDpeNPXAENo8iup1RJExcrgQcSX36V/Qwer/JcxNesfuRX2 itaw== X-Gm-Message-State: AOAM533ZWU3diLpoq03cKCmmr0elj2Mc1VWvBlKBvcx56kBDO5exFd0E lamxODuceSZac0XqB+83yeiKV29yz28QRFFK X-Google-Smtp-Source: ABdhPJzggjGeR+w5oInvl02M5PT2hcKkCkxgYNdvhcbz3aYnvz3CrMds78JZ4LAGkO5ppagebA8q+g== X-Received: by 2002:a17:90b:245:: with SMTP id fz5mr10126009pjb.131.1600015396843; Sun, 13 Sep 2020 09:43:16 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id y5sm6725057pge.62.2020.09.13.09.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 09:43:15 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id 03810C21840; Sun, 13 Sep 2020 09:43:13 -0700 (PDT) In-Reply-To: <87v9ghir7o.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Sep 2020 18:20:11 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=raman@google.com; helo=mail-pj1-x1035.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255523 Archived-At: Lars Ingebrigtsen writes: After pulling dc01b992e2 * Make the eww header work again even if the title is nil and building, I still find eww-update-header-line to be broken, stack trace attached. The issue doesn't repro if I load eww.el from emacs-27.1 Debugger entered--Lisp error: (wrong-type-argument stringp nil) (propertize nil face variable-pitch) (eww-update-header-line-format) (eval (eww-update-header-line-format) t) (#f(compiled-function (exp &optional insert-value no-truncate char-print-= limit) "Evaluate EXP and print value in the echo area.\nWhen called interac= tively, read an Emacs Lisp expression and\nevaluate it. Value is also cons= ed on to front of the variable\n`values'. Optional argument INSERT-VALUE n= on-nil (interactively,\nwith a non `-' prefix argument) means insert the re= sult into the\ncurrent buffer instead of printing it in the echo area.\n\nN= ormally, this function truncates long output according to the\nvalue of the= variables `eval-expression-print-length' and\n`eval-expression-print-level= '. When NO-TRUNCATE is\nnon-nil (interactively, with a prefix argument of = zero), however,\nthere is no such truncation.\n\nIf the resulting value is = an integer, and CHAR-PRINT-LIMIT is\nnon-nil (interactively, unless given a= non-zero prefix argument)\nit will be printed in several additional format= s (octal,\nhexadecimal, and character). The character format is used only\= nif the value is below CHAR-PRINT-LIMIT (interactively, if the\nprefix argu= ment is -1 or the value doesn't exceed\n`eval-expression-print-maximum-char= acter').\n\nRuns the hook `eval-expression-minibuffer-setup-hook' on enteri= ng the\nminibuffer.\n\nIf `eval-expression-debug-on-error' is non-nil, whic= h is the default,\nthis command arranges for all errors to enter the debugg= er." (interactive #f(compiled-function () #)) #= ) (eww-update-header-line-format) nil nil 127) (ad-Advice-eval-expression #f(compiled-function (exp &optional insert-val= ue no-truncate char-print-limit) "Evaluate EXP and print value in the echo = area.\nWhen called interactively, read an Emacs Lisp expression and\nevalua= te it. Value is also consed on to front of the variable\n`values'. Option= al argument INSERT-VALUE non-nil (interactively,\nwith a non `-' prefix arg= ument) means insert the result into the\ncurrent buffer instead of printing= it in the echo area.\n\nNormally, this function truncates long output acco= rding to the\nvalue of the variables `eval-expression-print-length' and\n`e= val-expression-print-level'. When NO-TRUNCATE is\nnon-nil (interactively, = with a prefix argument of zero), however,\nthere is no such truncation.\n\n= If the resulting value is an integer, and CHAR-PRINT-LIMIT is\nnon-nil (int= eractively, unless given a non-zero prefix argument)\nit will be printed in= several additional formats (octal,\nhexadecimal, and character). The char= acter format is used only\nif the value is below CHAR-PRINT-LIMIT (interact= ively, if the\nprefix argument is -1 or the value doesn't exceed\n`eval-exp= ression-print-maximum-character').\n\nRuns the hook `eval-expression-minibu= ffer-setup-hook' on entering the\nminibuffer.\n\nIf `eval-expression-debug-= on-error' is non-nil, which is the default,\nthis command arranges for all = errors to enter the debugger." (interactive #f(compiled-function () #)) #) (eww-update-header-= line-format) nil nil 127) (apply ad-Advice-eval-expression #f(compiled-function (exp &optional inse= rt-value no-truncate char-print-limit) "Evaluate EXP and print value in the= echo area.\nWhen called interactively, read an Emacs Lisp expression and\n= evaluate it. Value is also consed on to front of the variable\n`values'. = Optional argument INSERT-VALUE non-nil (interactively,\nwith a non `-' pref= ix argument) means insert the result into the\ncurrent buffer instead of pr= inting it in the echo area.\n\nNormally, this function truncates long outpu= t according to the\nvalue of the variables `eval-expression-print-length' a= nd\n`eval-expression-print-level'. When NO-TRUNCATE is\nnon-nil (interacti= vely, with a prefix argument of zero), however,\nthere is no such truncatio= n.\n\nIf the resulting value is an integer, and CHAR-PRINT-LIMIT is\nnon-ni= l (interactively, unless given a non-zero prefix argument)\nit will be prin= ted in several additional formats (octal,\nhexadecimal, and character). Th= e character format is used only\nif the value is below CHAR-PRINT-LIMIT (in= teractively, if the\nprefix argument is -1 or the value doesn't exceed\n`ev= al-expression-print-maximum-character').\n\nRuns the hook `eval-expression-= minibuffer-setup-hook' on entering the\nminibuffer.\n\nIf `eval-expression-= debug-on-error' is non-nil, which is the default,\nthis command arranges fo= r all errors to enter the debugger." (interactive #f(compiled-function () #= )) #) ((eww-update-= header-line-format) nil nil 127)) (eval-expression (eww-update-header-line-format) nil nil 127) (# eval-expression (eww-update-header-line-fo= rmat) nil nil 127) (apply # eval-expression ((eww-update-header-= line-format) nil nil 127)) (ad-Advice-funcall-interactively # eval-expre= ssion (eww-update-header-line-format) nil nil 127) (apply ad-Advice-funcall-interactively # (eva= l-expression (eww-update-header-line-format) nil nil 127)) (funcall-interactively eval-expression (eww-update-header-line-format) ni= l nil 127) (# eval-expression nil nil) (ad-Advice-call-interactively # eval-expression = nil nil) (apply ad-Advice-call-interactively # (eval-expr= ession nil nil)) (call-interactively eval-expression nil nil) (command-execute eval-expression) > "T.V Raman" writes: > >> In addition to the minibuffer eval results shown earlier, >> >> (propertize (plist-get eww-data :title) 'face 'variable-pitch) >> thorws the >> Debugger entered--Lisp error: (wrong-type-argument stringp nil) >> which is the same error that eww-update-header-line threw, >> while >> (plist-get eww-data :title) >> returns a string, >> >> Both of the above evaluated in the relevant stack frame via "e" > > If it's a bug somewhere, it sounds like a bug in the `e' command? > > In any case, I did push a fix for the title thing, so the bug should no > longer be present in Emacs 28 now. --=20 =817=A94 Id: kg:/m/0285kf1 =950=DC8