Re: [PATCH] timer-list -> list-timers?

[raman <raman@google.com>]

Mark Oteiza <mvoteiza@udel.edu> writes:

1+ I've stumbled over this more than once in the last few months > Hi,
>
> Why was this named timer-list?  While I understand there is a push to
> keep everything always in its own "namespace", list-foo is its own
> namespace, and is a useful one that collects special listings of
> different things around emacs.
>
> diff --git a/doc/lispref/os.texi b/doc/lispref/os.texi
> index 441fda5d82..af646ce40f 100644
> --- a/doc/lispref/os.texi
> +++ b/doc/lispref/os.texi
> @@ -1885,8 +1885,8 @@ Timers
>  cause anything special to happen.
>  @end defun
>  
> -@findex timer-list
> -The @code{timer-list} command lists all the currently active timers.
> +@findex list-timers
> +The @code{list-timers} command lists all the currently active timers.
>  There's only one command available in the buffer displayed: @kbd{c}
>  (@code{timer-list-cancel}) that will cancel the timer on the line
>  under point.
> diff --git a/lisp/emacs-lisp/timer-list.el b/lisp/emacs-lisp/timer-list.el
> index 44a315f980..69c6741983 100644
> --- a/lisp/emacs-lisp/timer-list.el
> +++ b/lisp/emacs-lisp/timer-list.el
> @@ -25,7 +25,7 @@
>  ;;; Code:
>  
>  ;;;###autoload
> -(defun timer-list (&optional _ignore-auto _nonconfirm)
> +(defun list-timers (&optional _ignore-auto _nonconfirm)
>    "List all timers in a buffer."
>    (interactive)
>    (pop-to-buffer-same-window (get-buffer-create "*timer-list*"))
> @@ -67,7 +67,7 @@ timer-list
>    (goto-char (point-min)))
>  ;; This command can be destructive if they don't know what they are
>  ;; doing.  Kids, don't try this at home!
> -;;;###autoload (put 'timer-list 'disabled "Beware: manually canceling timers can ruin your Emacs session.")
> +;;;###autoload (put 'list-timers 'disabled "Beware: manually canceling timers can ruin your Emacs session.")
>  
>  (defvar timer-list-mode-map
>    (let ((map (make-sparse-keymap)))
> @@ -84,7 +84,7 @@ timer-list-mode
>    (setq bidi-paragraph-direction 'left-to-right)
>    (setq truncate-lines t)
>    (buffer-disable-undo)
> -  (setq-local revert-buffer-function 'timer-list)
> +  (setq-local revert-buffer-function #'list-timers)
>    (setq buffer-read-only t)
>    (setq header-line-format
>          (format "%4s %10s %8s %s"
>

--