From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: raman Newsgroups: gmane.emacs.devel Subject: Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional Date: Wed, 06 Jul 2016 08:14:03 -0700 Message-ID: References: <2f8dfb88-8174-fa42-efd3-542605c881fd@yandex.ru> <83vb0in7o8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467818070 21977 80.91.229.3 (6 Jul 2016 15:14:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2016 15:14:30 +0000 (UTC) Cc: dgutov@yandex.ru, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 06 17:14:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bKoWt-0001uG-L8 for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2016 17:14:23 +0200 Original-Received: from localhost ([::1]:34119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKoWs-0002lO-SL for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2016 11:14:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKoWj-0002kB-H3 for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:14:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKoWe-0007X8-7J for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:14:13 -0400 Original-Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:35519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKoWd-0007Wu-Pd for emacs-devel@gnu.org; Wed, 06 Jul 2016 11:14:08 -0400 Original-Received: by mail-pa0-x234.google.com with SMTP id dx3so12624174pab.2 for ; Wed, 06 Jul 2016 08:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pk3Wdb3V5isozo0HR9S6zRAcsED/BTVj3brDgZLLekI=; b=JhMozNMaxJKMCTe+rXkK5x5+VjVHqFKVzSsBJ1kzXibbiBW7Ray0j+VjjiqpqdUpYW Z8O8KNkO8q4nodAfqhl9gkRzECnNmG739APkOErn3BT0MlZyr0dPrM+hcv4KPMn/EqmV +gZrVNbSS1dJbPc+rbuSeqDyt9n1NmvxlWWaKRExTPwdrqFhbBE61CvFgLKuJAjJxjqC 2lVXma44x4tuUPW7iODCCLvTGXyOMNvdL2fP9iaKVbZdmxNx4Em26/V/DwdSVpwdik+z ceV0DXnpwSe9SD7tU686q56vP37LGHMCEmZ4HDCDvpbWCrAv1pzXHpzEZJijHWR4dxdR tDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pk3Wdb3V5isozo0HR9S6zRAcsED/BTVj3brDgZLLekI=; b=dd7VdxmFjjT+vHq/btj+uu1OuBTlYmTwbxW2a6E6QXphYW45mO8sFi0MwBUwfu+u7E MYLkg0Srfz+vjGYdtJVIF21tsWKIhWQS3RYygBGbKD3pyrg9HKaeMc2jUuNaMYwWDLUz A6m7bIQSECfRHml9Rksqa1INXrQxFtZNncO1N3Y/Bg+rsMndsiVhkEs+345FVWKXR0q/ HgE3l9588DqFwF29yX2kwror7LcBcN36dyj7gFWo/d+OHwC118IiOpRUt2HpBKvrxM/x 5b3LP5Hp6PWVO6022+wdtkwlkbaY+wlYWAj9K6xFf/05SkHNZYqGcNj1Tl3fRC5Uo5Xw sw8w== X-Gm-Message-State: ALyK8tI8u38MpjbFvJO6GuSJiP/jLy9Gsb79s9F/BjX+1gKBweiAZjHO0bwY3L/KctZrj08l X-Received: by 10.66.43.7 with SMTP id s7mr17940072pal.27.1467818046698; Wed, 06 Jul 2016 08:14:06 -0700 (PDT) Original-Received: from raman-glaptop2 ([207.198.106.151]) by smtp.gmail.com with ESMTPSA id d69sm4487793pfj.31.2016.07.06.08.14.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 06 Jul 2016 08:14:06 -0700 (PDT) In-Reply-To: <83vb0in7o8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Jul 2016 17:49:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205260 Archived-At: Eli Zaretskii writes: >From memory the problem with called-interactively-p failing when called from inside an around advice remain, Stefan fixed part of the bug, but I also remember him saying that he was putting the rest of it on a stack for some future fix.>> From: raman >> Date: Tue, 05 Jul 2016 18:46:31 -0700 >> Cc: emacs-devel@gnu.org >> >> Here's one example of a large package (Emacspeak) and the number of >> times the equivalent of interactive-p is used: It would be interesting >> to validate the assertion "it's not used often" by examining other >> large packages as well. >> >> Note: ems-interactive-p is what I wrote when interactive-p got >> deprecated. >> >> grep ems-interactive-p *.el | wc >> 1607 4781 79080 >> Lines Of Elisp In Emacspeak: >> 18:44:33 raman-glaptop2 lisp $ wc *.el >> ... >> 79781 256614 2624155 total > > Did this change after Stefan fixed the bug you reported? Did you try > to see afterwards whether the problems you recall are still there or > solved? > --