unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: raman <raman@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dgutov@yandex.ru, emacs-devel@gnu.org
Subject: Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional
Date: Wed, 06 Jul 2016 08:14:03 -0700	[thread overview]
Message-ID: <p91oa6adcjo.fsf@google.com> (raw)
In-Reply-To: <83vb0in7o8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Jul 2016 17:49:11 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

From memory the problem  with called-interactively-p failing when called
from inside an around advice remain, Stefan fixed part of the bug, but I
also remember him saying that he was putting the rest of it on a stack
for some future fix.>> From: raman <raman@google.com>
>> Date: Tue, 05 Jul 2016 18:46:31 -0700
>> Cc: emacs-devel@gnu.org
>> 
>> Here's one example of a large package (Emacspeak) and the number of
>> times the equivalent of interactive-p is used: It would be interesting
>> to validate the assertion "it's not used often"  by examining other
>> large packages as well.
>> 
>> Note: ems-interactive-p is what I wrote when interactive-p got
>> deprecated.
>> 
>> grep ems-interactive-p *.el | wc
>>    1607    4781   79080
>> Lines Of Elisp In Emacspeak: 
>> 18:44:33 raman-glaptop2 lisp $ wc *.el
>>     ...
>>   79781  256614 2624155 total
>
> Did this change after Stefan fixed the bug you reported?  Did you try
> to see afterwards whether the problems you recall are still there or
> solved?
>

-- 



  reply	other threads:[~2016-07-06 15:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 20:35 Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional Robert Weiner
2016-06-28 19:09 ` John Wiegley
2016-06-28 20:28   ` Robert Weiner
2016-06-30 16:54   ` Andreas Röhler
2016-06-28 20:29 ` Glenn Morris
2016-06-28 20:46   ` Robert Weiner
2016-06-28 20:51     ` Robert Weiner
2016-06-29 20:02     ` Richard Stallman
2016-06-29 20:54       ` Robert Weiner
2016-06-29 21:19         ` Drew Adams
2016-06-29 21:39           ` Robert Weiner
2016-06-29 21:48             ` Robert Weiner
2016-06-30 23:18               ` Richard Stallman
2016-06-29 21:21         ` Clément Pit--Claudel
2016-06-29 21:52           ` Dmitry Gutov
2016-06-29 22:00             ` Robert Weiner
2016-06-30  2:51         ` raman
2016-06-30 14:25           ` Robert Weiner
2016-06-30 15:30             ` Eli Zaretskii
2016-07-03 18:36               ` Andreas Röhler
2016-07-03 18:56                 ` Alan Mackenzie
2016-07-03 19:57                   ` Andreas Röhler
2016-07-03 19:31                 ` Eli Zaretskii
2016-06-30 15:34             ` raman
2016-07-03  0:10         ` Richard Stallman
2016-07-06  0:09   ` John Wiegley
2016-07-06  0:21     ` Dmitry Gutov
2016-07-06  0:31       ` John Wiegley
2016-07-06  1:46         ` raman
2016-07-06  2:05           ` Dmitry Gutov
2016-07-06 14:49           ` Eli Zaretskii
2016-07-06 15:14             ` raman [this message]
2016-07-06 14:48         ` Eli Zaretskii
2016-07-06 15:20           ` Robert Weiner
2016-07-06  0:24     ` Noam Postavsky
2016-07-06  5:03       ` Robert Weiner
2016-07-06  6:45         ` Andreas Röhler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p91oa6adcjo.fsf@google.com \
    --to=raman@google.com \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).