From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 Date: Sun, 13 Sep 2020 08:27:32 -0700 Message-ID: References: <24414.11044.596033.388237@google.com> <87363llnou.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 17:28:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHTvS-00005L-0p for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 17:28:22 +0200 Original-Received: from localhost ([::1]:48806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHTvR-0006v6-1l for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 11:28:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHTul-00061v-S7 for emacs-devel@gnu.org; Sun, 13 Sep 2020 11:27:39 -0400 Original-Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:44666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHTuj-00059U-PU for emacs-devel@gnu.org; Sun, 13 Sep 2020 11:27:39 -0400 Original-Received: by mail-pf1-x431.google.com with SMTP id o20so10435361pfp.11 for ; Sun, 13 Sep 2020 08:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6rIgDtjYEmtDCTpjq/WpoDp8q3lpNbo+YxLg3de/31k=; b=mDyE3S49/5sjpXH4Hfn9kIj1SsUnVOLAR2UeY7WxAsW/QpZVS1KMaexk5sF8LB75NK gclTohcx0wG7PBfi9LA7pCpN2SV6ITg0wDHtDsQvQldNjY54G9J3//nHOCVAXY0gbxeS nqAvEfAe1iVWQ1D8In542fQrCxJ0NKuIVCn20a3ceL23A453Qdhmv+4k5dMcy58JGtPw 8WhiEEu0FwZWkItZuqsWxFbnerRO7JCXhNLt0vF3D7QnZURFSzhqKbS+Gej5mVXFviqq e4fQsSfGXa9ekfZHP/S2HcjyNbLHdaAhGZu/3Xzae1B+Rmg5GHhbFixf2AHRNPN4qRfu abuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6rIgDtjYEmtDCTpjq/WpoDp8q3lpNbo+YxLg3de/31k=; b=TlJ2nlyb/We5GG9RCP5cLGTH2YzGTciXK5sZFAI9+Qb4wHQCoAP0lxddpGlzICD2jI +uaHL2eWchHizOH530NKBc8y2r1xtsL82GytrOcc5gv+VY0BwjHCKaoaJ2aBqh+QFL5f wvW/8aIo49CzN9H65O87mE1+MlF71f9UGGH0Vc3qsIQ6WEbpBANQZDhe3Y8TrjDmfxq1 1KXe8UE1REvLFf5v1BIOhGwWXb7ng5mfu7B+N5T+cUIbQVuC15aflZ7DV+J8q6GtxdTt b+jgQKFDIzFaUUFvN/8sF8gXivEo7cIoDkbwNsfH8F++ibD3GzFl8e8kHxEbS0w+0sCh 4uNg== X-Gm-Message-State: AOAM532Tdyfu9E/QITlNNlYUEU6Dl2n5ntc6XV3nNEEnK2VOGHKUE1XA lbf4dQUTInEVW3XnV1fkl9a8j32vB/8ZLUr2 X-Google-Smtp-Source: ABdhPJzwUT9e4M4u/oOIw1rLm8oFNIN1R8Mb6ozdF3F4ah1RWKBG879VoL0smk1cjWV+oIm9DgrH6w== X-Received: by 2002:a63:2203:: with SMTP id i3mr7404781pgi.405.1600010855407; Sun, 13 Sep 2020 08:27:35 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id x7sm6700309pjv.16.2020.09.13.08.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 08:27:34 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id 5D9C4C215EE; Sun, 13 Sep 2020 08:27:32 -0700 (PDT) In-Reply-To: <87363llnou.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Sep 2020 17:08:01 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=raman@google.com; helo=mail-pf1-x431.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255509 Archived-At: Lars Ingebrigtsen writes: eww-update-header-line was seeing the title as nil which is what surprized me. So: with the rendered buffer as current buffer, evaluating these in the minibuffer: (plist-get eww-data :title) returned the title I had set, but evaluating (eww-update-header-line) in the minibuffer threw an error, with the debugger showing that propertize had been called with a null string > "T.= V Raman" writes: > >> I'm setting eww-data correctly, and plist-get shows that :title is set >> correctly in eww-data when I go to the buffer where the ebook is >> rendered. However eww-update-header-line throws an error on this line: >> >> + (let ((title (propertize (plist-get eww-data :title) >> >> appears that plist-get in the above call returns nil within >> eww-update-header-line --not sure why=20 > > If that bugs out, then :title in eww-data can't be a string, I think? > > But I see that the old code supported a nil value for title, so I've now > tweaked the code a bit to avoid bugging out in this case. Pushed to the > trunk now. --=20 =817=A94 Id: kg:/m/0285kf1 =950=DC8