From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: master@head: completing-read behavior change? Date: Thu, 23 Jan 2020 06:44:28 -0800 Message-ID: References: <24104.57455.730537.220936@retriever.mtv.corp.google.com> <24104.57963.869782.597096@retriever.mtv.corp.google.com> <24104.58069.333584.189273@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="77139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 18:40:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iugSf-000K2t-AK for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 18:40:09 +0100 Original-Received: from localhost ([::1]:33730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iugSd-0000YK-W6 for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 12:40:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36592) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iudik-0003C3-Ct for emacs-devel@gnu.org; Thu, 23 Jan 2020 09:44:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iudij-0001W8-8U for emacs-devel@gnu.org; Thu, 23 Jan 2020 09:44:34 -0500 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:37971) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iudij-0001VM-13 for emacs-devel@gnu.org; Thu, 23 Jan 2020 09:44:33 -0500 Original-Received: by mail-pl1-x62a.google.com with SMTP id t6so1444487plj.5 for ; Thu, 23 Jan 2020 06:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KRtJSBhkCXnSGWbI+hLyeu5VaxEAq/9XcPPhQ8qNvzI=; b=olS5e/Ec+pjL5YP71ZVTSAs+tPGDPMYXYQGH/fbxXPKmnetBWZ8pC6rC1sg0J/JFHu fVfJvHH88TYJN7Qf2EC4eD6zVyOqgLYuPfpihLTdrolka6ikeAx3hLqJKlKa6FYtc8zZ i6+Nwf18m2ZHSIkXhZRcHxt1hBCNiaNaFf9XxhSRCr96GYckvggoXMVUgBjopujD9bpq 6apR0yCs5VgSMDUJ30z5sGj3QRXPJGzSRQqlLsnNfh3gSfaFwo6P7snOXiYnCQKs960S GxfOZ1E7mPcncO+y+Lggv/4Yl+jmbqOU3qCtdHr6AqiOhrGVQYyKhT6SVIqDchhqI4qG UloQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KRtJSBhkCXnSGWbI+hLyeu5VaxEAq/9XcPPhQ8qNvzI=; b=NL65fE0lv2jud4imd43AXkFIPHsYGk+3RlAnMBPB4WA/FaPL3L12gwz37vOpz5Ra38 XQAqw0EAcRU0UrEny87rU5S+vdCmMWRhatRqfEXirz20jjvqhwLvNtFcWsS7Mt5SbEL7 PxcKJy3Qbz1+DMqhfl+u04xW0wLwolMg1yIKYW1J5ygULzz2Ymq3G2zqEGs6VMffzqJI ONm3Y1aKD9S7X/z0hJsaodfj33GCuYA8oe5iuYTHCo9SRvEMIQ41H+kH01Ucc209WZiM Z681yUOF3+h1e18NGI13NFygdmKNQqIksNKTCzCeBC+SmpcYwvptszXl13e4q0XhO+i7 ucHA== X-Gm-Message-State: APjAAAUpPdvOnIymIWxDC1/s2Ft2JeSTnqAY5daUZ4+TpDgdgBYEZFhW jFOKYp/ht5MI2HMKzQncomxdqQgCBYc= X-Google-Smtp-Source: APXvYqxwZuPpKTndgPhmH97kegAQDAOzrWxB71BeGKwX9wd7mFK4+9DNNLefDLwpuMEj8RPc3PyORA== X-Received: by 2002:a17:902:16a:: with SMTP id 97mr16378655plb.163.1579790671188; Thu, 23 Jan 2020 06:44:31 -0800 (PST) Original-Received: from raman-glaptop.localdomain (189.8.197.35.bc.googleusercontent.com. [35.197.8.189]) by smtp.gmail.com with ESMTPSA id s185sm3082557pfc.35.2020.01.23.06.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 06:44:30 -0800 (PST) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id 37ABFC2085A; Thu, 23 Jan 2020 06:44:28 -0800 (PST) In-Reply-To: (Dmitry Gutov's message of "Thu, 23 Jan 2020 16:58:09 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244540 Archived-At: Dmitry Gutov writes: will check icomplete when I have time, I frankly dont remember any more whether I handle it. What would be a simple test usage for icomplete? I have ido, flx-ido and ido-ubiquitous (can never remember its new name) active, so as you can guess my emacs world is complex.> Hi T.V., > > On 23.01.2020 3:03, T.V Raman wrote: >> Fix is here for the curious:-) >> https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85 > > You haven't answered my question about support for icomplete-mode. Do > you only support Ido? > > I'm happy you made it work, but I think it would be better to handle > the general approach. Meaning, instead of hardcoding the names of > (private) variables, scan the minibuffer, look for the overlays with > after-string, order by 'priority', and read their contents one after > another. > > The new set-minibuffer-message feature uses the same approach if > minibuffer is active. Although, in that case, you could advise this > function, or set an alternative handler via the set-message-function > variable (also just added in Emacs 27). > --