From: "T.V Raman" <raman@google.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: shr-copy-url: arg misnamed?
Date: Sun, 23 Sep 2018 16:45:01 -0700 [thread overview]
Message-ID: <p914leflqwy.fsf@google.com> (raw)
In-Reply-To: <CAM-tV-9CvZGqoqOTaC0FAigx9N89Q3_t-fmU9N4SP_5H1VoFqQ@mail.gmail.com> (Noam Postavsky's message of "Sun, 23 Sep 2018 16:04:40 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
What I meant was:
Interactive form returns "url" to fill-in its arg (url) --- agree re the
cut-and-paste error.
Not sure why I typed "shadowed" -- what I meant was that the naming of
"url" is confusing
(interactive (list (shr-url-at-point current-prefix-arg)))
> On Sat, 22 Sep 2018 at 12:22, T.V Raman <raman@google.com> wrote:
>>
>> Should the arg in this function be renamed?
>>
>> The name "url" is confusing, and is likely being shadowed
>
> Not sure what you mean by shadowed, but the docstring has a copy-paste
> mistake: it should say "with a prefix argument" instead of referencing
> IMAGE-URL (which is an arg of shr-url-at-point).
--
next prev parent reply other threads:[~2018-09-23 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 16:12 shr-copy-url: arg misnamed? T.V Raman
2018-09-23 20:04 ` Noam Postavsky
2018-09-23 23:45 ` T.V Raman [this message]
2018-09-25 0:42 ` Noam Postavsky
2018-09-25 7:31 ` Andreas Schwab
2018-09-25 13:55 ` T.V Raman
2018-09-25 14:27 ` Noam Postavsky
2018-09-23 20:57 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p914leflqwy.fsf@google.com \
--to=raman@google.com \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).