From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: raman Newsgroups: gmane.emacs.devel Subject: Re: eww: call to eww-render looks incorrect Date: Sun, 03 Sep 2017 08:52:20 -0700 Message-ID: References: <83d177ygng.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1504454011 22596 195.159.176.226 (3 Sep 2017 15:53:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Sep 2017 15:53:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 03 17:53:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doXCo-0004dG-QB for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2017 17:53:02 +0200 Original-Received: from localhost ([::1]:55213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doXCv-0001xZ-OV for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2017 11:53:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doXCH-0001wQ-3c for emacs-devel@gnu.org; Sun, 03 Sep 2017 11:52:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doXCC-0003eW-GT for emacs-devel@gnu.org; Sun, 03 Sep 2017 11:52:29 -0400 Original-Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:34273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doXCC-0003dn-BA for emacs-devel@gnu.org; Sun, 03 Sep 2017 11:52:24 -0400 Original-Received: by mail-pg0-x22e.google.com with SMTP id t193so12677073pgc.1 for ; Sun, 03 Sep 2017 08:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=Aw1veTHOytyUiAcGrPlKYWXTQUIR2lqbhVNHB9/u6ZU=; b=aZH/S4/3iGGPtRW4I8PCi3TCeg0MB0WgaVShcUhg1Xn5JCaSZs1Xw6JgvrN3MBoC8q hoNmRtKMgUqao0jhrlClPmYuvhU6RlEr9ONNJGqaIigVVMW9NRjTfR7THQ9lW359S35G 4CfTl0xy9Vk3tX/MBQeSmEIyFXb5nOSJiCyk2jhBSSPw76TgjycY4ZiF9I+TilnUY1Bw SBoApMxhHjbdbSaYK9nDAuLOaXHmhQEicR6NnfngwuLJpMxRfI+15oMivFvNeQxVoaX1 HikeNsBF2XrttTTeEGolTQXGCKNgXTgBLJ63xSm6pDfmgtTLJpBP6sOpFlKtkuLpKBYA 7mTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=Aw1veTHOytyUiAcGrPlKYWXTQUIR2lqbhVNHB9/u6ZU=; b=mO5Oq7ZIoeHabupEXPiK3u2X2A8K16Hq0/A2i8XcAo8VvobkGz0Ku5kuvBysvz6bbA LUxSd/PZhjS/Wg0L4nEKLHd3IBOvxWZFR3kD0YnjzXEpFXhQ88PcWNh20+J1iiErmP2r 6mM4OVhrLrcVwTtWqm5bHFOxOS5DGaDNtauHY5J0u0BgYK2d7ErFV7vJQxZEY/B/03R+ vj5lBJKM8BMul8U5eJv5SGni6RIbTuMIB8NbqHHoYj4RaBkN0b6wejjNuj5VM0kvn44t whatPSp5Dz+NigPjdI9y8JxPRD6eFSVyFBfWm/SykWi3BvMwSxJSBqj/mlNWojaoWEoS vNdw== X-Gm-Message-State: AHPjjUgq3QHnh2fZujmtUpB1lTF+Gz1iT71Xdodr1KY1SpIIlvNIkjuK kzfKMWbr+SbOdIr5OeRc5g== X-Google-Smtp-Source: ADKCNb7JdyQqmvcdoFptWBR1qBIuMpjaBBgD8d5SVjjDqc+3GCIgfd09w9VsPX2bz94EhtLAHlk9dQ== X-Received: by 10.84.232.8 with SMTP id h8mr9442986plk.188.1504453942835; Sun, 03 Sep 2017 08:52:22 -0700 (PDT) Original-Received: from raman-glaptop2 (c-73-170-121-60.hsd1.ca.comcast.net. [73.170.121.60]) by smtp.gmail.com with ESMTPSA id l13sm3552085pgu.46.2017.09.03.08.52.21 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 03 Sep 2017 08:52:21 -0700 (PDT) In-Reply-To: <83d177ygng.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Sep 2017 17:56:51 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217915 Archived-At: Eli Zaretskii writes: I might be confused -- reading that signature I thought status should be passed first, the call I see passes url first >> Date: Sat, 02 Sep 2017 15:38:09 -0700 >> From: raman >> >> In function eww: >> >> eww-render is the callback to url-retrieve: line 267 >> (url-retrieve url 'eww-render >> (list url nil (current-buffer)))) >> The order of arguments in that list looks wrong --- at least per >> the definition of eww-render, which is (status url buffer &rest args) > > In the current master eww-render's signature is > > (defun eww-render (status url &optional point buffer encode) > > So I think the CBARGS argument of url-retrieve in that case is > correct, do you agree? --