unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: raman <raman@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: eww: call to eww-render looks incorrect
Date: Sun, 03 Sep 2017 08:52:20 -0700	[thread overview]
Message-ID: <p911snn7paj.fsf@raman-glaptop2> (raw)
In-Reply-To: <83d177ygng.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Sep 2017 17:56:51 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

I might be confused -- reading that signature I thought status should be
 passed first, the call I see passes url first >> Date: Sat, 02 Sep 2017 15:38:09 -0700
>> From: raman <raman@google.com>
>> 
>> In function eww:
>> 
>> eww-render is the callback to url-retrieve: line 267
>> (url-retrieve url 'eww-render
>> 		(list url nil (current-buffer))))
>> The order of arguments in that list looks wrong --- at least per
>> the definition of eww-render, which is (status url buffer &rest args)
>
> In the current master eww-render's signature is
>
>   (defun eww-render (status url &optional point buffer encode)
>
> So I think the CBARGS argument of url-retrieve in that case is
> correct, do you agree?

-- 



  reply	other threads:[~2017-09-03 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02 22:38 eww: call to eww-render looks incorrect raman
2017-09-03 14:56 ` Eli Zaretskii
2017-09-03 15:52   ` raman [this message]
2017-09-03 16:27     ` Eli Zaretskii
2017-09-03 17:50       ` raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p911snn7paj.fsf@raman-glaptop2 \
    --to=raman@google.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).