Re: MPS: commit limit

[Pip Cet <pipcet@protonmail.com>]

On Tuesday, July 16th, 2024 at 15:16, Helmut Eller <eller.helmut@gmail.com> wrote:
> On Mon, Jul 08 2024, Gerd Möllmann wrote:
> 
> > Sometimes it works just fine, sometimes not. For example, with 1 << 29,
> > I get a nice memory full when dumping, always. With 1 << 30, only the
> > expensice ert-test triggers something, namely the assertion in MPS.
> 
> 
> This patch adds a igc--set-commit-limit function. It doesn't fix the
> problem with the assertion. People who use the hot MPS build will
> probably see a normal memory full error and probably have to quit soon
> after that. The others see the failed assertion and abort immediately.
> So the end result will not be much different.

I'm not sure about that one. Should we really expose a function we know to be buggy in the single implementation that people are likely to use? I don't understand why you made it invalid to set the commit limit to SIZE_MAX, because that is a valid commit limit, and what the MPS explicitly suggests you should set the commit limit to.

> The other two patches are minor cleanups.

Those look good to me Sorry, again, for taking so long with the current patch set, which touches this same code (and indeed does the same thing for igc_assert()...)

BTW, are you still running performance tests? I've found it helps a lot to play with the "pause time" and "initial area size" parameters. I can run pidigits in 9 seconds now, on my Android phone (optimized build and all that) :-)

And unlike the commit limit, setting the pause time appears to work, so maybe we should expose that to. I don't know how to expose the generation chain settings yet, since they're set at pool creation time.

Pip