* SIGTYPE/RETSIGTYPE
@ 2011-03-26 19:34 Glenn Morris
2011-03-27 1:14 ` SIGTYPE/RETSIGTYPE Paul Eggert
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2011-03-26 19:34 UTC (permalink / raw)
To: emacs-devel
The autoconf manual says:
Obsolete Macros: AC_TYPE_SIGNAL
If signal.h declares signal as returning a pointer to a function
returning void, define RETSIGTYPE to be void; otherwise, define it
to be int. These days, it is portable to assume C89, and that signal
handlers return void, without needing to use this macro or RETSIGTYPE.
So is it OK to remove this test from Emacs's configure.in, and replace
RETSIGTYPE (and SIGTYPE, which we define equal to RETSIGTYPE in
AH_BOTTOM) with just `void' everywhere in the sources?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: SIGTYPE/RETSIGTYPE 2011-03-26 19:34 SIGTYPE/RETSIGTYPE Glenn Morris @ 2011-03-27 1:14 ` Paul Eggert 2011-03-27 2:30 ` SIGTYPE/RETSIGTYPE Glenn Morris 0 siblings, 1 reply; 4+ messages in thread From: Paul Eggert @ 2011-03-27 1:14 UTC (permalink / raw) To: Glenn Morris; +Cc: emacs-devel On 03/26/2011 12:34 PM, Glenn Morris wrote: > So is it OK to remove this test from Emacs's configure.in, and replace > RETSIGTYPE (and SIGTYPE, which we define equal to RETSIGTYPE in > AH_BOTTOM) with just `void' everywhere in the sources? Yes, absolutely. Other GNU projects have done that for years, with no problems. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: SIGTYPE/RETSIGTYPE 2011-03-27 1:14 ` SIGTYPE/RETSIGTYPE Paul Eggert @ 2011-03-27 2:30 ` Glenn Morris 2011-03-27 3:09 ` SIGTYPE/RETSIGTYPE Paul Eggert 0 siblings, 1 reply; 4+ messages in thread From: Glenn Morris @ 2011-03-27 2:30 UTC (permalink / raw) To: Paul Eggert; +Cc: emacs-devel Thanks; removed. Now the only things that `autoreconf -Wall' still gripes about are in lib/ and m4/. ;) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: SIGTYPE/RETSIGTYPE 2011-03-27 2:30 ` SIGTYPE/RETSIGTYPE Glenn Morris @ 2011-03-27 3:09 ` Paul Eggert 0 siblings, 0 replies; 4+ messages in thread From: Paul Eggert @ 2011-03-27 3:09 UTC (permalink / raw) To: Glenn Morris; +Cc: emacs-devel On 03/26/2011 07:30 PM, Glenn Morris wrote: > Now the only things that `autoreconf -Wall' still gripes about are in > lib/ and m4/. ;) The gripes about AC_GNU_SOURCE are because gnulib is still intended to be portable to Autoconf 2.59, which doesn't have the replacements for AC_GNU_SOURCE. These gripes should go away once gnulib is modernized to assume a later Autoconf. The other gripe, about DEFAULT_INCLUDES, is due to the way Emacs historically has put config.h into src. Most other packages put it into lib, and if we did that we could remove the DEFAULT_INCLUDES bit and fix the gripe. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-27 3:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-26 19:34 SIGTYPE/RETSIGTYPE Glenn Morris 2011-03-27 1:14 ` SIGTYPE/RETSIGTYPE Paul Eggert 2011-03-27 2:30 ` SIGTYPE/RETSIGTYPE Glenn Morris 2011-03-27 3:09 ` SIGTYPE/RETSIGTYPE Paul Eggert
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).