From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley Date: Wed, 14 Apr 2010 13:50:58 +0200 Message-ID: References: <1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1271245899 1190 80.91.229.12 (14 Apr 2010 11:51:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Apr 2010 11:51:39 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 14 13:51:38 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O2184-00021F-Gf for ged-emacs-devel@m.gmane.org; Wed, 14 Apr 2010 13:51:36 +0200 Original-Received: from localhost ([127.0.0.1]:50538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O217y-0007oA-OS for ged-emacs-devel@m.gmane.org; Wed, 14 Apr 2010 07:51:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O217u-0007nz-0i for emacs-devel@gnu.org; Wed, 14 Apr 2010 07:51:26 -0400 Original-Received: from [140.186.70.92] (port=44067 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O217s-0007nl-M3 for emacs-devel@gnu.org; Wed, 14 Apr 2010 07:51:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O217q-0000We-Rh for emacs-devel@gnu.org; Wed, 14 Apr 2010 07:51:24 -0400 Original-Received: from mail-bw0-f225.google.com ([209.85.218.225]:64974) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O217q-0000VY-04 for emacs-devel@gnu.org; Wed, 14 Apr 2010 07:51:22 -0400 Original-Received: by bwz25 with SMTP id 25so18909bwz.8 for ; Wed, 14 Apr 2010 04:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:received:message-id:subject:to:cc:content-type; bh=zeoja7UcRdxdKwNoT4oJbQwIiKRC75+u83SCz5yhYkY=; b=ORVwb/onXzJcfYeATLnMrb58LTWVlrRK6hbXNaQnBnhMCzlFQdfFQ9/5NHxUJbWCQU Gkue2s5BTZ/RzMS3IezjJWwAgspWAxZB8WH0wms8mSSKpGg36Hm6EYzFK07bKgOc9OR9 Wx21M9wtIEE6Y6FbYqltZn7OUVzDVN8Ixp3eY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=MoRa9eR2u56l0DipbrFF31m3cBQ3Cpq9tioa7sDBC6LLZqQyj5/R3d67l0WpTDBvZT KkLevl/A1yNF7cAR3ayAFsy5im3kOGWTE3NkroppLYof9Oc/yt6leTxQIKbE8d8vugFt bkoHI7vciKkD3pYNXBQDGyZWHfi8IqaCkrbfY= Original-Received: by 10.204.136.15 with HTTP; Wed, 14 Apr 2010 04:50:58 -0700 (PDT) In-Reply-To: <1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com> Original-Received: by 10.204.6.81 with SMTP id 17mr8401774bky.62.1271245878435; Wed, 14 Apr 2010 04:51:18 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123626 Archived-At: I'm not sure the virtual buffers behavior makes much sense for ido-kill-buffer. You cannot "kill" nonexistent buffers, you *don't* want to kill the file, and you cannot kill the entry from the buffer list. So, I think either the following patch should be installed (plus changes to a few docstrings, of course) or ido-kill-buffer "fixed" to remove the nonbuffer entry from the buffer list. The problem with that second option is that, to work right, it should either modify the recentf list (which would likely be surprising to the user), or jump a few hoops to maintain a list of buffers killed from the ido list but still present into the recentf list. A bit hackish for so short a reward, IMHO. Juanma === modified file 'lisp/ido.el' --- lisp/ido.el 2010-04-06 18:17:55 +0000 +++ lisp/ido.el 2010-04-14 11:40:45 +0000 @@ -4078,5 +4078,6 @@ For details of keybindings, see `ido-switch-buffer'." (interactive) - (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: " (buffer-name (current-buffer)) nil 'ignore)) + (let (ido-use-virtual-buffers) + (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: " (buffer-name (current-buffer)) nil 'ignore))) ;;;###autoload