From: Juanma Barranquero <lekktu@gmail.com>
To: John Wiegley <jwiegley@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com>
Date: Wed, 14 Apr 2010 13:50:58 +0200 [thread overview]
Message-ID: <o2of7ccd24b1004140450qf631bd9fj1d61ef18293e12c5@mail.gmail.com> (raw)
In-Reply-To: <1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com>
I'm not sure the virtual buffers behavior makes much sense for
ido-kill-buffer. You cannot "kill" nonexistent buffers, you *don't*
want to kill the file, and you cannot kill the entry from the buffer
list.
So, I think either the following patch should be installed (plus
changes to a few docstrings, of course) or ido-kill-buffer "fixed" to
remove the nonbuffer entry from the buffer list. The problem with that
second option is that, to work right, it should either modify the
recentf list (which would likely be surprising to the user), or jump a
few hoops to maintain a list of buffers killed from the ido list but
still present into the recentf list. A bit hackish for so short a
reward, IMHO.
Juanma
=== modified file 'lisp/ido.el'
--- lisp/ido.el 2010-04-06 18:17:55 +0000
+++ lisp/ido.el 2010-04-14 11:40:45 +0000
@@ -4078,5 +4078,6 @@
For details of keybindings, see `ido-switch-buffer'."
(interactive)
- (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: "
(buffer-name (current-buffer)) nil 'ignore))
+ (let (ido-use-virtual-buffers)
+ (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: "
(buffer-name (current-buffer)) nil 'ignore)))
;;;###autoload
prev parent reply other threads:[~2010-04-14 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NyK5I-00040x-CT@internal.in.savannah.gnu.org>
2010-04-04 18:20 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com> Stefan Monnier
2010-04-04 18:27 ` John Wiegley
2010-04-14 11:50 ` Juanma Barranquero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o2of7ccd24b1004140450qf631bd9fj1d61ef18293e12c5@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).