Re: emacs/lisp/net dbus.el

Re: emacs/lisp/net dbus.el

[Glenn Morris]

Michael Albinus wrote:

> 	* net/dbus.el (dbus-init-bus): Declare.  Apply it for the :system
> 	and :session buses.

I seem to be unable to build Emacs since this change.
On a RHEL5 GNU/Linux system, the build fails with:

Compiling /scratch/gmorris/emacs/cvs/trunk/lisp/net/xesam.el

In toplevel form:
net/xesam.el:135:1:Error: D-Bus error: "Failed to execute dbus-launch to autolaunch D-Bus session"
make[2]: *** [/scratch/gmorris/emacs/cvs/trunk/lisp/net/xesam.elc] Error 1
make[2]: *** Waiting for unfinished jobs....

And I get left with dbus processes sitting around after the build exits:

gmorris  28103     1  0 20:47 pts/10   00:00:00 dbus-launch --autolaunch 2df34d46e8c4cbef2fd63845699b1400 --binary-syntax --close-st
gmorris  28104     1  0 20:47 ?        00:00:00 /bin/dbus-daemon --fork --print-pid 7 --print-address 9 --session

Re: emacs/lisp/net dbus.el

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Michael Albinus wrote:
>
>> 	* net/dbus.el (dbus-init-bus): Declare.  Apply it for the :system
>> 	and :session buses.
>
> I seem to be unable to build Emacs since this change.

Should be fixed now. Sorry.

Best regards, Michael.

Re: emacs/lisp/net dbus.el

[Glenn Morris]

Michael Albinus wrote:

> Should be fixed now. Sorry.

Thanks; now it builds, but the build still leaves me with dbus-launch
and dbus-daemon processes running after make finishes.

If it's relevant, I was building by logging in via ssh to a system
where I had an X session running, which seemed to be spawned via
dbus-launch.

Re: emacs/lisp/net dbus.el

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Thanks; now it builds, but the build still leaves me with dbus-launch
> and dbus-daemon processes running after make finishes.
>
> If it's relevant, I was building by logging in via ssh to a system
> where I had an X session running, which seemed to be spawned via
> dbus-launch.

Could you, please, check whether the D-Bus processes do run already
before the build? I have embedded the dbus-init-bus calls into a check
for $DBUS_SESSION_BUS_ADDRESS; this environment variable exists only
when you have a running D-Bus session bus.

In your case, no additional D-Bus processes shall be launched by
compiling or loading dbus.el. If so, then it might be due to other
reasons (maybe a bug which persists longer).

Best regards, Michael.

Re: emacs/lisp/net dbus.el

[Glenn Morris]

Michael Albinus wrote:

> Could you, please, check whether the D-Bus processes do run already
> before the build? I have embedded the dbus-init-bus calls into a check
> for $DBUS_SESSION_BUS_ADDRESS; this environment variable exists only
> when you have a running D-Bus session bus.
>
> In your case, no additional D-Bus processes shall be launched by
> compiling or loading dbus.el. If so, then it might be due to other
> reasons (maybe a bug which persists longer).

This still happens. It's definitely a new dbus process (not least
because when I logout from my ssh session, it hangs waiting for these
dbus processes to be killed).

This is a RHEL5 system. I have an X session running. This is started as:

ssh-agent execs dbus-launch
dbus-launch execs ~/.xsession
(this seems to create a dbus-daemon process as well)

If I just do

emacs -Q -l dbus

in my X session, no new dbus processes are started.

But if I do:

ssh my-local-host
emacs -Q -l dbus

then two new dbus processes are started:

dbus-launch --autolaunch STRING --binary-syntax --close-stderr
dbus-daemon -fork --print-pid 5 --print-address 7 --session

These persist after Emacs exits, and I have to kill them before I can
logout of my ssh connection.

Re: emacs/lisp/net dbus.el

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> But if I do:
>
> ssh my-local-host
> emacs -Q -l dbus
>
> then two new dbus processes are started:
>
> dbus-launch --autolaunch STRING --binary-syntax --close-stderr
> dbus-daemon -fork --print-pid 5 --print-address 7 --session
>
> These persist after Emacs exits, and I have to kill them before I can
> logout of my ssh connection.

I've commited a patch for dbusbind.c. Before connecting to the session
bus, there is now a check for $DBUS_SESSION_BUS_ADDRESS. By this,
unintended autostart shall be avoided.

Best regards, Michael.

Re: emacs/lisp/net dbus.el

[Glenn Morris]

Michael Albinus wrote:

> I've commited a patch for dbusbind.c. Before connecting to the session
> bus, there is now a check for $DBUS_SESSION_BUS_ADDRESS. By this,
> unintended autostart shall be avoided.

Works for me. Thanks.