* DocView broken!
@ 2008-01-09 23:33 Angelo Graziosi
2008-01-10 11:30 ` Tassilo Horn
0 siblings, 1 reply; 4+ messages in thread
From: Angelo Graziosi @ 2008-01-09 23:33 UTC (permalink / raw)
To: emacs-devel
It seems that in current CVS 23.0.50 the DocVies is broken.
Now when I try to visit a PDF file in the minibuffer I see:
File mode specification error: (void-function tramp-tramp-file-p)
and the file is shown as a text (Text mode).
Typing C-c C-c it says: undefined !!!
With the build I did yesterday it works fine.
This happens with Cygwin and GNU/Linux builds.
Cheers,
Angelo.
---
Facesti come quei che va di notte,
che porta il lume dietro e se' non giova,
ma dopo se' fa le persone dotte.
---
DANTE, Purgatorio, xxii 67-69
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: DocView broken!
2008-01-09 23:33 DocView broken! Angelo Graziosi
@ 2008-01-10 11:30 ` Tassilo Horn
2008-01-10 12:49 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2008-01-10 11:30 UTC (permalink / raw)
To: Angelo Graziosi; +Cc: emacs-devel
Angelo Graziosi <angelo.graziosi@alice.it> writes:
Hi Angelo,
> Now when I try to visit a PDF file in the minibuffer I see:
>
> File mode specification error: (void-function tramp-tramp-file-p)
>
> and the file is shown as a text (Text mode).
Sorry, my bad. I checked in a fix for this a minute ago.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: DocView broken!
2008-01-10 11:30 ` Tassilo Horn
@ 2008-01-10 12:49 ` Michael Albinus
2008-01-10 13:40 ` Tassilo Horn
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2008-01-10 12:49 UTC (permalink / raw)
To: Tassilo Horn; +Cc: emacs-devel, Angelo Graziosi
Tassilo Horn <tassilo@member.fsf.org> writes:
Hi Tassilo,
>> Now when I try to visit a PDF file in the minibuffer I see:
>>
>> File mode specification error: (void-function tramp-tramp-file-p)
>>
>> and the file is shown as a text (Text mode).
>
> Sorry, my bad. I checked in a fix for this a minute ago.
Your approach to require Tramp is not clean I fear. There are users
who don't use Tramp at all. Furthermore, tramp-tramp-file-p is not a
documented function, that means it could change without any notice.
Better would be to apply (file-remote-p buffer-file-name)
Furthermore, you shall check (stringp buffer-file-name) at all - try
"M-x doc-view-mode" when you are in *scratch* ...
> Bye,
> Tassilo
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: DocView broken!
2008-01-10 12:49 ` Michael Albinus
@ 2008-01-10 13:40 ` Tassilo Horn
0 siblings, 0 replies; 4+ messages in thread
From: Tassilo Horn @ 2008-01-10 13:40 UTC (permalink / raw)
To: Michael Albinus; +Cc: Angelo Graziosi, emacs-devel
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Michael,
> Your approach to require Tramp is not clean I fear. There are users
> who don't use Tramp at all. Furthermore, tramp-tramp-file-p is not a
> documented function, that means it could change without any notice.
>
> Better would be to apply (file-remote-p buffer-file-name)
Ok, I'll change that.
> Furthermore, you shall check (stringp buffer-file-name) at all - try
> "M-x doc-view-mode" when you are in *scratch* ...
Right.
Thanks for the pointers,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-10 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-09 23:33 DocView broken! Angelo Graziosi
2008-01-10 11:30 ` Tassilo Horn
2008-01-10 12:49 ` Michael Albinus
2008-01-10 13:40 ` Tassilo Horn
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).