unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Trent W. Buck" <trentbuck@gmail.com>
Cc: emacs-pretest-bug@gnu.org, rfrancoise@debian.org
Subject: Host name for su(do)? (was: Tramp 2.0 -> 2.1 migration woes)
Date: Mon, 28 Jan 2008 15:50:16 +0100	[thread overview]
Message-ID: <nqfxwigg2f.fsf@alcatel-lucent.de> (raw)
In-Reply-To: 20080128023016.GB3075@Clio.twb.ath.cx

"Trent W. Buck" <trentbuck@gmail.com> writes:

>> The appended patch shall fix it. Could you, please, test?
>
> Yes, that seems to work, but I would extend the whitelist:
>
> - The class A network 127.0.0.0/8
> - The unqualified system name (e.g. Clio instead of Clio.twb.ath.cx)
> - The comparison should be case-insensitive.
>
> Obviously this whitelist will never be perfect, e.g. if "mail" is a
> CNAME alias in on the DNS server for the local host, /sudo:mail: is
> meaningful but it would be hard to catch that.

The typical use case for "su" and "sudo" are file names like
"/sudo::/file". Therefore, I don't believe we shall invest too much in
the whitelist. "127.0.0.1" as host name doesn't seem to be needed; if
somebody uses it, s?he will be taught not to do.

`system-name' will mostly the unqualified system name I believe, so it
is already compliant to your request. Or am I wrong?

> Maybe instead of an error, it should show a warning and continue?  I'm
> not sure how you could make a warning pop up so that it would be seen
> by the user.  Obviously `message' wouldn't work, because the echo area
> would be reused as tramp continued to sudo'ing to localhost.

That was my first idea as well. But it isn't so simple to implement,
and there would be still the problem that a file name is shown as
"/sudo:otherhost:/file", although you are on the local host. It might
be inconvenient to get an error, but the user will learn very fast
that "/sudo::/file" or "/sudo:user@localhost:/file" is the better
choice.

> I would also change the error message to read
>
>     "Host `foo' looks like a remote host, `sudo' can only use the
>     local host."

OK, I'll do so.

Best regards, Michael.

  reply	other threads:[~2008-01-28 14:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27  4:00 Tramp 2.0 -> 2.1 migration woes Trent W. Buck
2008-01-27 13:42 ` Michael Albinus
2008-01-28  2:13   ` Trent W. Buck
2008-01-28 15:32     ` Michael Albinus
2008-01-28 15:57       ` Trent W. Buck
2008-01-28 16:31         ` Michael Albinus
2008-01-29  0:34           ` Trent W. Buck
2008-01-31 11:00             ` Michael Albinus
2008-01-31 14:51               ` Stefan Monnier
2008-01-31 15:46                 ` Michael Albinus
2008-01-27 14:57 ` Michael Albinus
2008-01-28  2:30   ` Trent W. Buck
2008-01-28 14:50     ` Michael Albinus [this message]
2008-01-28 15:46       ` Host name for su(do)? (was: Tramp 2.0 -> 2.1 migration woes) Trent W. Buck
2008-01-28 16:10         ` Host name for su(do)? Michael Albinus
2008-01-28 21:47           ` Michael Albinus
2008-01-28 20:54 ` Shell-command is no longer a shell (was: Tramp 2.0 -> 2.1 migration woes) Michael Albinus
2008-01-29  0:43   ` Trent W. Buck
2008-01-29 21:06     ` Shell-command is no longer a shell Michael Albinus
2008-01-31  2:09       ` Trent W. Buck
2008-01-29 20:58 ` sudo -s -H (was: Tramp 2.0 -> 2.1 migration woes) Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nqfxwigg2f.fsf@alcatel-lucent.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=rfrancoise@debian.org \
    --cc=trentbuck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).