From: zv <zv@nxvr.org>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] Complete temperature units in calc-convert-temperature
Date: Fri, 19 Feb 2016 15:41:37 -0800 [thread overview]
Message-ID: <na897h$dk0$1@ger.gmane.org> (raw)
In-Reply-To: <20160219174232.GA11806@holos>
On 02/19/2016 09:42 AM, Mark Oteiza wrote:
> ---
> IIUC, user defined units cannot be temperatures, so deriving
> a collection of temperature units from math-standard-units as opposed to
> the generated math-units-tables should be fine.
>
> diff --git a/lisp/calc/calc-units.el b/lisp/calc/calc-units.el
> index 07d9ac9..525e3e2 100644
> --- a/lisp/calc/calc-units.el
> +++ b/lisp/calc/calc-units.el
> @@ -565,7 +565,12 @@ If COMP or STD is non-nil, put that in the units table instead."
> (defun calc-convert-temperature (&optional old-units new-units)
> (interactive)
> (calc-slow-wrapper
> - (let ((expr (calc-top-n 1))
> + (let ((tempunits (delq nil
> + (mapcar
> + (lambda (x)
> + (if (nth 3 x) (car x)))
> + math-standard-units)))
> + (expr (calc-top-n 1))
> (uold nil)
> (uoldname nil)
> unew
> @@ -580,15 +585,16 @@ If COMP or STD is non-nil, put that in the units table instead."
> (car units)))))
> (error "Not a pure temperature expression"))
> (math-read-expr
> - (setq uoldname (read-string
> - "Old temperature units: ")))))))
> + (setq uoldname (completing-read
> + "Old temperature units: "
> + tempunits)))))))
> (when (eq (car-safe uold) 'error)
> (error "Bad format in units expression: %s" (nth 2 uold)))
> (or (math-units-in-expr-p expr nil)
> (setq expr (math-mul expr uold)))
> (setq defunits (math-get-default-units expr))
> (setq unew (or new-units
> - (read-string
> + (completing-read
> (concat
> (if uoldname
> (concat "Old temperature units: "
> @@ -599,7 +605,8 @@ If COMP or STD is non-nil, put that in the units table instead."
> (concat " (default "
> defunits
> "): ")
> - ": ")))))
> + ": "))
> + tempunits)))
> (setq unew (math-read-expr (if (string= unew "") defunits unew)))
> (when (eq (car-safe unew) 'error)
> (error "Bad format in units expression: %s" (nth 2 unew)))
>
>
Synchronicity! Too weird, I was just working on a patch for this.
prev parent reply other threads:[~2016-02-19 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 17:42 [PATCH] Complete temperature units in calc-convert-temperature Mark Oteiza
2016-02-19 23:41 ` zv [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='na897h$dk0$1@ger.gmane.org' \
--to=zv@nxvr.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).