From: Andreas Schwab <schwab@suse.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: emacs-26 c87d04e: Avoid aborts in 'md5'
Date: Wed, 28 Feb 2018 17:32:30 +0100 [thread overview]
Message-ID: <mvmpo4prs69.fsf@suse.de> (raw)
In-Reply-To: <83inahyuq9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Feb 2018 17:55:26 +0200")
On Feb 28 2018, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Andreas Schwab <schwab@suse.de>
>> Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
>> Date: Wed, 28 Feb 2018 10:15:04 +0100
>>
>> > See bug#30627.
>>
>> So the CHECK_STRING should be put in the else branch.
>
> In general, safe code should check STRINGP before using SSDATA, so the
> way I did it is safer (and also more future-proof).
All branches already use SSDATA or SBYTES before that, so nothing is
gained.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2018-02-28 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180227164448.16622.42058@vcs0.savannah.gnu.org>
[not found] ` <20180227164448.E4B45207B1@vcs0.savannah.gnu.org>
2018-02-28 8:30 ` emacs-26 c87d04e: Avoid aborts in 'md5' Michael Albinus
2018-02-28 8:49 ` Andreas Schwab
2018-02-28 9:09 ` Michael Albinus
2018-02-28 9:15 ` Andreas Schwab
2018-02-28 15:55 ` Eli Zaretskii
2018-02-28 16:32 ` Andreas Schwab [this message]
2018-02-28 17:24 ` Eli Zaretskii
2018-02-28 19:14 ` Paul Eggert
2018-02-28 20:35 ` Eli Zaretskii
2018-02-28 22:14 ` Paul Eggert
2018-03-01 3:39 ` Eli Zaretskii
2018-02-28 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmpo4prs69.fsf@suse.de \
--to=schwab@suse.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).