* [phromo@gmail.com: bugfix: python.el: completion in inferior python]
@ 2008-01-18 13:28 Richard Stallman
2008-01-20 3:58 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Richard Stallman @ 2008-01-18 13:28 UTC (permalink / raw)
To: emacs-devel
Would someone please DTRT?
------- Start of forwarded message -------
Message-ID: <478E0C9B.8080302@gmail.com>
Date: Wed, 16 Jan 2008 14:54:35 +0100
From: Martin Svenson <phromo@gmail.com>
MIME-Version: 1.0
To: bug-gnu-emacs@gnu.org
Content-Type: multipart/mixed; boundary="------------000101040702080309060500"
Subject: bugfix: python.el: completion in inferior python
This is a multi-part message in MIME format.
- --------------000101040702080309060500
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Hello,
I've fixed a small "bug" that affects, among others,
python-complete-symbol in the inferior python buffer.
Problem (and solution):
When doing python-complete-symbol in the inferior python buffer, emacs
freezes. This is due to a while-loop in python-symbol-completions that
never gets any input, because the python process signals an error that
python-imports is nil (because we're not in an python-edit-buffer). The
correct value of python-imports in an unknown context should not be nil
(as in current version), but "None", which makes things work smoothly
and as expected.
P.S. This is my first time sending a patch to an open-source project. I
apolgize if my message does not conform with etiquette.
// Martin
- --------------000101040702080309060500
Content-Type: text/plain;
name="python-el-completion-fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="python-el-completion-fix.patch"
KioqIHB5dGhvbi5lbC5vbGQJV2VkIEphbiAxNiAxNDoyOTowNCAyMDA4Ci0tLSBweXRob24u
ZWwJV2VkIEphbiAxNiAxNDo0Njo1OCAyMDA4CioqKioqKioqKioqKioqKgoqKiogMTg0OCwx
ODU0ICoqKioKICAMDQogIDs7OzsgQ29tcGxldGlvbi4NCiAgDQohIChkZWZ2YXIgcHl0aG9u
LWltcG9ydHMgbmlsDQogICAgIlN0cmluZyBvZiB0b3AtbGV2ZWwgaW1wb3J0IHN0YXRlbWVu
dHMgdXBkYXRlZCBieSBgcHl0aG9uLWZpbmQtaW1wb3J0cycuIikNCiAgKG1ha2UtdmFyaWFi
bGUtYnVmZmVyLWxvY2FsICdweXRob24taW1wb3J0cykNCiAgDQotLS0gMTg0OCwxODU0IC0t
LS0KICAMDQogIDs7OzsgQ29tcGxldGlvbi4NCiAgDQohIChkZWZ2YXIgcHl0aG9uLWltcG9y
dHMgIk5vbmUiDQogICAgIlN0cmluZyBvZiB0b3AtbGV2ZWwgaW1wb3J0IHN0YXRlbWVudHMg
dXBkYXRlZCBieSBgcHl0aG9uLWZpbmQtaW1wb3J0cycuIikNCiAgKG1ha2UtdmFyaWFibGUt
YnVmZmVyLWxvY2FsICdweXRob24taW1wb3J0cykNCiAgDQo=
- --------------000101040702080309060500--
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [phromo@gmail.com: bugfix: python.el: completion in inferior python]
2008-01-18 13:28 [phromo@gmail.com: bugfix: python.el: completion in inferior python] Richard Stallman
@ 2008-01-20 3:58 ` Glenn Morris
2008-01-20 9:19 ` Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python]) Reiner Steib
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Glenn Morris @ 2008-01-20 3:58 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Richard Stallman wrote:
> Would someone please DTRT?
ack.
PS please find a way to forward mails that does not corrupt attachments.
> From: Martin Svenson <phromo@gmail.com>
> Subject: bugfix: python.el: completion in inferior python
> To: bug-gnu-emacs@gnu.org
> Date: Wed, 16 Jan 2008 14:54:35 +0100
^ permalink raw reply [flat|nested] 7+ messages in thread
* Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python])
2008-01-20 3:58 ` Glenn Morris
@ 2008-01-20 9:19 ` Reiner Steib
2008-01-20 20:28 ` Forwarding mails Glenn Morris
2008-01-20 9:28 ` [phromo@gmail.com: bugfix: python.el: completion in inferior python] Andreas Schwab
2008-01-20 20:29 ` Glenn Morris
2 siblings, 1 reply; 7+ messages in thread
From: Reiner Steib @ 2008-01-20 9:19 UTC (permalink / raw)
To: Glenn Morris; +Cc: rms, emacs-devel
On Sun, Jan 20 2008, Glenn Morris wrote:
> PS please find a way to forward mails that does not corrupt attachments.
Didn't C-d (`gnus-summary-enter-digest-group') work for you? I think
Richard's current way is better than previously. It now includes the
original Message-ID making it easier to find the original thread
(e.g. using Gnus or on Gmane).
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [phromo@gmail.com: bugfix: python.el: completion in inferior python]
2008-01-20 3:58 ` Glenn Morris
2008-01-20 9:19 ` Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python]) Reiner Steib
@ 2008-01-20 9:28 ` Andreas Schwab
2008-01-20 20:29 ` Glenn Morris
2 siblings, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2008-01-20 9:28 UTC (permalink / raw)
To: Glenn Morris; +Cc: rms, emacs-devel
Glenn Morris <rgm@gnu.org> writes:
> PS please find a way to forward mails that does not corrupt attachments.
Actually Gnus can handle them, and I don't see anything obviously
broken.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Forwarding mails
2008-01-20 9:19 ` Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python]) Reiner Steib
@ 2008-01-20 20:28 ` Glenn Morris
2008-01-20 21:03 ` Reiner Steib
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2008-01-20 20:28 UTC (permalink / raw)
To: emacs-devel
Reiner Steib wrote:
> Didn't C-d (`gnus-summary-enter-digest-group') work for you?
Yes (in that it sends me to a buffer with two messages, one empty with
subject (none) from nobody, one the original message); but I didn't
know about that command.
PS given that Gnus can discard duplicate messages, and the mailing
list can be set to not send you duplicates anyway, do you really need
to insert a Mail-Followup-To header? It means Gnus starts composing my
followup as to: rms, which makes little sense, since I'm replying to
you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [phromo@gmail.com: bugfix: python.el: completion in inferior python]
2008-01-20 3:58 ` Glenn Morris
2008-01-20 9:19 ` Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python]) Reiner Steib
2008-01-20 9:28 ` [phromo@gmail.com: bugfix: python.el: completion in inferior python] Andreas Schwab
@ 2008-01-20 20:29 ` Glenn Morris
2 siblings, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2008-01-20 20:29 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Glenn Morris wrote:
> PS please find a way to forward mails that does not corrupt attachments.
Please ignore that comment, it seems I was mistaken.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Forwarding mails
2008-01-20 20:28 ` Forwarding mails Glenn Morris
@ 2008-01-20 21:03 ` Reiner Steib
0 siblings, 0 replies; 7+ messages in thread
From: Reiner Steib @ 2008-01-20 21:03 UTC (permalink / raw)
To: Glenn Morris; +Cc: ding, emacs-devel
[ Including ding@gnus, as it's becoming (only) Gnus related. Feel
free to strip emacs-devel on reply. ]
On Sun, Jan 20 2008, Glenn Morris wrote:
> Reiner Steib wrote:
>> Didn't C-d (`gnus-summary-enter-digest-group') work for you?
>
> Yes (in that it sends me to a buffer with two messages, one empty with
> subject (none) from nobody, one the original message);
I can't reproduce this. After one `C-d', I get a summary buffer like
this:
| Martin Svenson bugfix: python.el: completion in inferior python
With another `C-d', I get:
| m n/a Martin Svenson <* mixed> bugfix: python.el: completion [...]
| n/a Martin Svenson <1 text>
| n/a Martin Svenson <2 text> "python-el-completion-fix.patch"
> but I didn't know about that command.
I didn't know that `gnus-summary-enter-digest-group' can handle it,
but after someone mentioned some rmail undigest command, I just tried
it. ;-)
> PS given that Gnus can discard duplicate messages, and the mailing
> list can be set to not send you duplicates anyway,
I'm not subscribed to emacs-devel, I read it via Gmane, so I don't get
duplicates in the first place.
> do you really need to insert a Mail-Followup-To header?
I split Cc-ed mailing list message to special Gnus group, so it's no
big deal to receive Cc's, but they are not necessary for me. If it is
annoying for you, I try to avoid it in the future.
> It means Gnus starts composing my followup as to: rms, which makes
> little sense, since I'm replying to you.
Does `message-dont-reply-to-names' include your name or address? In
this case, Gnus shouldn't reply to you, I think (I'm to lazy to look
into the code).
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-01-20 21:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-18 13:28 [phromo@gmail.com: bugfix: python.el: completion in inferior python] Richard Stallman
2008-01-20 3:58 ` Glenn Morris
2008-01-20 9:19 ` Forwarding mails (was: [phromo@gmail.com: bugfix: python.el: completion in inferior python]) Reiner Steib
2008-01-20 20:28 ` Forwarding mails Glenn Morris
2008-01-20 21:03 ` Reiner Steib
2008-01-20 9:28 ` [phromo@gmail.com: bugfix: python.el: completion in inferior python] Andreas Schwab
2008-01-20 20:29 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).