unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: "Vincent Belaïche" <vincent.b.1@hotmail.fr>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: cal-tex.el landscape patch
Date: Thu, 24 Aug 2017 21:10:22 -0400	[thread overview]
Message-ID: <mr2w0mozl.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <AM5PR10MB0676F7138C70F7D0EECD1AA584870@AM5PR10MB0676.EURPRD10.PROD.OUTLOOK.COM> ("Vincent \=\?utf-8\?Q\?Bela\=C3\=AFche\=22's\?\= message of "Mon, 21 Aug 2017 14:19:28 +0000")


Fine by me, thanks. Trivial comments below.

> -(defun cal-tex-preamble (&optional args)
> +(defun cal-tex-preamble (&optional class-options)
>    "Insert the LaTeX calendar preamble into `cal-tex-buffer'.
>  Preamble includes initial definitions for various LaTeX commands.
> -Optional string ARGS are included as options for the article document class."
> +Optional string CLASS-OPTIONS are included as options for the article document class."
>    (set-buffer (generate-new-buffer cal-tex-buffer))
>    (insert (format "\\documentclass%s{article}\n"
> -                  (if (stringp args)
> -                      (format "[%s]" args)
> +                  (if (stringp class-options)
> +                      (format "[%s]" class-options)
>                      "")))
> +  (if (and (stringp class-options) (string-match "\\<landscape\\>" class-options))
> +      (insert "\\usepackage{geometry}\n"))


I'd prefer if the argument did not get renamed.


> -(defun cal-tex-insert-preamble (weeks landscape size &optional append)
> +(defun cal-tex-insert-preamble (weeks class-options &optional append)
>    "Initialize the output LaTeX calendar buffer, `cal-tex-buffer'.
>  Select the output buffer, and insert the preamble for a calendar
> -of WEEKS weeks.  Insert code for landscape mode if LANDSCAPE is
> -non-nil.  Use point-size SIZE.  Optional argument APPEND, if
> -non-nil, means add to end of buffer without erasing current contents."
> -  (let ((width "18cm")
> +of WEEKS weeks.  Insert code for landscape mode if CLASS-OPTIONS
> +contains landscape option. 
> +Optional argument APPEND, if non-nil, means add to end of buffer
> +without erasing current contents."

"Insert code for landscape mode if CLASS-OPTIONS contains landscape
option." seems a bit vague to me. Maybe something like

"Pass string CLASS-OPTIONS as options for the article document class.
If it contains \"landscape\", use the geometry package to produce
landscape format."

Maybe class-options could be optional, and default to "12pt"?



  parent reply	other threads:[~2017-08-25  1:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 14:19 cal-tex.el landscape patch Vincent Belaïche
2017-08-22  7:04 ` Marcin Borkowski
2017-08-22 22:05   ` Vincent Belaïche
2017-08-25  1:10 ` Glenn Morris [this message]
2017-08-25  9:07   ` Vincent Belaïche
2017-08-25 17:58     ` Vincent Belaïche
2017-08-25 18:25       ` Edward Reingold
2017-08-26 15:06         ` Vincent Belaïche
2017-08-26 15:29           ` Vincent Belaïche
2017-08-28 17:20             ` Paul Eggert
2017-08-28 17:55             ` Glenn Morris
2017-08-30  9:45               ` Vincent Belaïche
2017-09-14 12:46                 ` Vincent Belaïche
2017-09-14 20:31                   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mr2w0mozl.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=vincent.b.1@hotmail.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).