From: Glenn Morris <rgm@gnu.org>
To: Richard Stallman <rms@gnu.org>
Cc: martin rudalics <rudalics@gmx.at>, emacs-devel@gnu.org
Subject: loop in backup-copy-buffer
Date: Tue, 21 Aug 2007 17:59:21 -0400 [thread overview]
Message-ID: <m4hcmsy2fa.fsf@fencepost.gnu.org> (raw)
You added the (potentially infinite) loop in backup-buffer-copy a few
years ago. Looks like it was adapted from make-temp-name. I can see it
might make sense to loop while trying to make a tempfile name, but was
there ever a case where this was found to be necessary when backing
up? Can we just get rid of this loop? The ChangeLog entry is not
helpful as to why such a loop might be needed.
2005-04-23 Richard M. Stallman <rms@gnu.org>
* files.el (read-directory-name): Always pass non-nil
DEFAULT-FILENAME arg to read-file-name.
(backup-buffer-copy, basic-save-buffer-2): Take care
against writing thru an unexpected existing symlink.
next reply other threads:[~2007-08-21 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 21:59 Glenn Morris [this message]
2007-08-22 3:15 ` loop in backup-copy-buffer Richard Stallman
2007-08-22 3:55 ` Glenn Morris
2007-08-23 21:18 ` Stefan Monnier
2007-08-24 16:10 ` Richard Stallman
2007-08-24 17:42 ` Stefan Monnier
2007-08-25 20:52 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m4hcmsy2fa.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).