From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Pavel@Janik.cz (Pavel =?iso-8859-2?q?Jan=EDk?=) Newsgroups: gmane.emacs.devel Subject: Re: mouse-wheel mode (and probably other stuff) broken due to use of global-map Date: Sun, 24 Mar 2002 19:26:47 +0100 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200203160639.g2G6dVk07398@wijiji.santafe.edu> <3C972B46.2040604@anubex.com> <200203210903.g2L93fk10046@wijiji.santafe.edu> <3C99C227.6030803@anubex.com> <200203211654.g2LGsNG17870@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable X-Trace: main.gmane.org 1017000934 6329 127.0.0.1 (24 Mar 2002 20:15:34 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 24 Mar 2002 20:15:34 +0000 (UTC) Cc: Tim Van Holder , rms@gnu.org, emacs-devel@gnu.org Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 16pEOs-0001dy-00 for ; Sun, 24 Mar 2002 21:15:34 +0100 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 16pEWa-00074D-00 for ; Sun, 24 Mar 2002 21:23:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16pEOc-0004OJ-00; Sun, 24 Mar 2002 15:15:18 -0500 Original-Received: from p0526.as-l043.contactel.cz ([194.108.244.18] helo=SnowWhite.SuSE.cz) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16pEMS-0004Kk-00; Sun, 24 Mar 2002 15:13:05 -0500 Original-Received: by SnowWhite.SuSE.cz (PJ, from userid 500) id 47F33183CC; Sun, 24 Mar 2002 21:15:40 +0100 (CET) Original-To: "Stefan Monnier" Mail-Copies-To: never X-Face: $"d&^B_IKlTHX!y2d,3;grhwjOBqOli]LV`6d]58%5'x/kBd7.MO&n3bJ@Zkf&RfBu|^qL+ ?/Re{MpTqanXS2'~Qp'J2p^M7uM:zp[1Xq#{|C!*'&NvCC[9!|=>#qHqIhroq_S"MH8nSH+d^9*BF: iHiAs(t(~b#1.{w.d[=Z In-Reply-To: <200203211654.g2LGsNG17870@rum.cs.yale.edu> ("Stefan Monnier"'s message of "Thu, 21 Mar 2002 11:54:23 -0500") User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2.50 (i386-suse-linux-gnu) Original-Lines: 39 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:2172 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:2172 From: "Stefan Monnier" Date: Thu, 21 Mar 2002 11:54:23 -0500 > > - (define-key global-map key 'mwheel-scroll)) > > - ((eq (lookup-key global-map key) 'mwheel-scroll) > > - (define-key global-map key nil)))) > > + (define-key (current-global-map) key 'mwheel-scroll= )) > > + ((eq (lookup-key (current-global-map) key) 'mwheel-s= croll) > > + (define-key (current-global-map) key nil)))) > > (error nil)))) >=20 > I'd use `global-set-key' since that's what it's for after all. Yes. Can anyone test the following change? --- mwheel.el.~1.11.~ Sun Mar 24 15:52:02 2002 +++ mwheel.el Sun Mar 24 19:25:25 2002 @@ -169,9 +169,9 @@ (condition-case () (dolist (key keys) (cond (mouse-wheel-mode - (define-key (current-global-map) key 'mwheel-scroll)) + (global-set-key key 'mwheel-scroll)) ((eq (lookup-key (current-global-map) key) 'mwheel-scroll) - (define-key (current-global-map) key nil)))) + (global-unset-key key)))) (error nil)))) =20 ;;; Compatibility entry point --=20 Pavel Jan=EDk That's the problem: pretesters aren't finding many more bugs nowadays, so it'll probably take until 2005 to find and fix enough bugs that we can comfortably announce the code stable. -- Stefan Monnier in comp.emacs _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel