From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: bug? the position of scroll-bar
Date: 22 Sep 2003 14:23:54 +0200 [thread overview]
Message-ID: <m3zngx3tb9.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <20030922.182241.152505591.jet@gyve.org>
Masatake YAMATO <jet@gyve.org> writes:
> > > A width of nil and type of t means to use the frame's corresponding value.
> Thank you. I've validated more strictly.
That's too much now :-)
The doc string is unclear. What it's supposed to say is:
If WIDTH is nil, use the frame's scroll-bar width.
If TYPE is t, use the frame's scroll-bar type.
So just allow type = t with no check on width...
And fix the doc string :-)
> How about this one?
>
> 2003-09-22 Masatake YAMATO <jet@gyve.org>
>
> * window.c (Fset_window_scroll_bars): Validate the value of
> `vertical_type'.
>
> Index: src/window.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/window.c,v
> retrieving revision 1.447
> diff -u -r1.447 window.c
> --- src/window.c 20 Sep 2003 23:38:54 -0000 1.447
> +++ src/window.c 22 Sep 2003 09:18:19 -0000
> @@ -5873,6 +5873,12 @@
> if (XINT (width) == 0)
> vertical_type = Qnil;
>
> + if (!(EQ (vertical_type, Qnil)
> + || EQ (vertical_type, Qleft)
> + || EQ (vertical_type, Qright)
> + || (EQ (vertical_type, Qt) && NILP (width))))
> + error ("Invalid type of vertical scroll bar");
> +
> if (!EQ (w->scroll_bar_width, width)
> || !EQ (w->vertical_scroll_bar_type, vertical_type))
> {
>
>
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2003-09-22 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-17 11:48 bug? the position of scroll-bar Masatake YAMATO
2003-09-21 0:02 ` Kim F. Storm
2003-09-21 5:51 ` Masatake YAMATO
2003-09-22 7:56 ` Kim F. Storm
2003-09-22 9:22 ` Masatake YAMATO
2003-09-22 12:23 ` Kim F. Storm [this message]
2003-09-21 22:34 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zngx3tb9.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).