From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Add M-x occur to the menu-bar Date: 10 Feb 2004 15:50:06 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3F69E6FF.9050702@yahoo.com> <4n8yjto16h.fsf@collins.bwh.harvard.edu> <4nisixjibl.fsf@collins.bwh.harvard.edu> <20040127230323.GB5407@fencepost> <4n7jzc919v.fsf@collins.bwh.harvard.edu> <4nn085i7nl.fsf@collins.bwh.harvard.edu> <4noese37h0.fsf@collins.bwh.harvard.edu> <4nbrodxwqm.fsf@collins.bwh.harvard.edu> <4n8yjcccvj.fsf@collins.bwh.harvard.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1076421513 26089 80.91.224.253 (10 Feb 2004 13:58:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 Feb 2004 13:58:33 +0000 (UTC) Cc: Ted Zlatanov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Feb 10 14:58:23 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AqYP9-0008Tz-00 for ; Tue, 10 Feb 2004 14:58:23 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AqYP9-0008Qy-00 for ; Tue, 10 Feb 2004 14:58:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqYI6-0001za-OJ for emacs-devel@quimby.gnus.org; Tue, 10 Feb 2004 08:51:06 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AqYHs-0001z2-Av for emacs-devel@gnu.org; Tue, 10 Feb 2004 08:50:52 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AqYHM-0001uM-Ia for emacs-devel@gnu.org; Tue, 10 Feb 2004 08:50:51 -0500 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.24) id 1AqYHL-0001uA-N2 for emacs-devel@gnu.org; Tue, 10 Feb 2004 08:50:20 -0500 Original-Received: (qmail 51393 invoked from network); 10 Feb 2004 13:50:17 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 10 Feb 2004 13:50:17 -0000 Original-To: rms@gnu.org In-Reply-To: Original-Lines: 26 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19853 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19853 Richard Stallman writes: > + (if (buffer-local-value > + 'compilation-next-error-function > + compilation-last-buffer) > + ;; do the right thing for modes that bind compilation-next-error-function > > It is cleaner to check for a non-nil value than to > check for a local binding. I don't follow... We need to check if the buffer-local value of the variable compilation-next-error-function is non-nil in the compilation-last-buffer buffer. Is this what you suggest to use instead? (if (with-current-buffer compilation-last-buffer compilation-next-error-function) ... If so, what's the difference? -- Kim F. Storm http://www.cua.dk