From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: valid_pointer_p Date: Sun, 06 Aug 2006 00:11:30 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1154816001 6765 80.91.229.2 (5 Aug 2006 22:13:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 5 Aug 2006 22:13:21 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 06 00:13:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G9UOP-0002G2-Ez for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2006 00:13:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G9UOO-0007bg-Rg for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2006 18:13:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G9UOE-0007bE-F9 for emacs-devel@gnu.org; Sat, 05 Aug 2006 18:13:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G9UOD-0007au-1Y for emacs-devel@gnu.org; Sat, 05 Aug 2006 18:13:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G9UOC-0007ar-Vb for emacs-devel@gnu.org; Sat, 05 Aug 2006 18:13:00 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G9US3-0003RU-H5; Sat, 05 Aug 2006 18:16:59 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id 718FBA50025; Sun, 6 Aug 2006 00:12:55 +0200 (CEST) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Sat, 05 Aug 2006 16:04:22 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58133 Archived-At: Eli Zaretskii writes: >> Cc: emacs-devel@gnu.org >> From: storm@cua.dk (Kim F. Storm) >> Date: Mon, 31 Jul 2006 11:01:26 +0200 >> >> Eli Zaretskii writes: >> >> > If no one else cares about this, I will at least write the code to >> > DTRT on Windows. >> >> Please do. > > Done. > > Btw, you always try to validate a 16-byte region starting at the > address P, which might give a false positive if the object is actually > smaller and happens to be at the end of an allocated page which is > followed by a page that we cannot access. Am I missing something? I validate a 16 area since the pointer is typically something "vector-like" where the code that access/print that object will look at data following the immedate byte/word that the pointer addresses. So I made the "safe choice" of checking 16 bytes. -- Kim F. Storm http://www.cua.dk