Re: shell-command - missing shell-quote-argument for program?

[storm@cua.dk (Kim F. Storm)]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:

> The author of filesets Thomas Link has replied to me that he currently 
> does not use Emacs and cannot maintain filesets.el until that situation 
> changes.
>
> I myself therefore suggest the following patch to filesets.el:

Isolated, it looks ok, but if you look at filesets-quote, maybe
it should use shell-quote-argment too, and we should
use filesets-quote on buffer-file-name below.

But it's too complex for me to follow the logic in filesets.

>
> Index: filesets.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/filesets.el,v
> retrieving revision 1.29
> diff -c -r1.29 filesets.el
> *** filesets.el    13 Aug 2006 17:05:12 -0000    1.29
> --- filesets.el    6 Oct 2006 13:15:12 -0000
> ***************
> *** 1701,1707 ****
>             ok)
>             t)))
>       (when ok
> !       (let ((cmd (format txt (buffer-file-name))))
>       (message "Filesets: %s" cmd)
>       (filesets-cmd-show-result cmd
>                     (shell-command-to-string cmd))))))
> --- 1701,1707 ----
>             ok)
>             t)))
>       (when ok
> !       (let ((cmd (format txt (shell-quote-argument (buffer-file-name)))))
>       (message "Filesets: %s" cmd)
>       (filesets-cmd-show-result cmd
>                     (shell-command-to-string cmd))))))

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk