From: Andreas Schwab <schwab@linux-m68k.org>
To: emacs-devel@gnu.org
Subject: Re: Buffer size limitation in insdel.c
Date: Thu, 23 Sep 2010 15:12:40 +0200 [thread overview]
Message-ID: <m3zkv8mwmv.fsf@hase.home> (raw)
In-Reply-To: <m3wrqcocdg.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 23 Sep 2010 14:47:23 +0200")
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> dispnew.c:783: warning: conversion to 'int' from 'Lisp_Object' may alter its value
This is an obvious bug. A Lisp_Object value must never be treated as an
integer, and this will fail to compile with --enable-use-lisp-union-type
(which is a good idea to enable during development).
> dispnew.c:2178: warning: conversion to 'long unsigned int' from 'short int' may change the sign of the result
>
> size_t nbytes = from->used[TEXT_AREA] * sizeof (struct glyph);
This is only a problem if from->used[TEXT_AREA] can be negative, which
it can't. Might be worth to change to unsigned short.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-09-23 13:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 12:06 Buffer size limitation in insdel.c Eli Zaretskii
2010-09-22 12:12 ` Lars Magne Ingebrigtsen
2010-09-22 15:20 ` Eli Zaretskii
2010-09-22 12:16 ` David Kastrup
2010-09-23 0:06 ` Stefan Monnier
2010-09-23 0:58 ` Richard Stallman
2010-09-23 7:55 ` Eli Zaretskii
2010-09-23 9:23 ` Leo
2010-09-23 9:30 ` Eli Zaretskii
2010-09-23 10:59 ` Lars Magne Ingebrigtsen
2010-09-23 12:15 ` Eli Zaretskii
2010-09-23 12:18 ` Lars Magne Ingebrigtsen
2010-09-23 12:47 ` Lars Magne Ingebrigtsen
2010-09-23 13:12 ` Andreas Schwab [this message]
2010-09-23 13:22 ` Eli Zaretskii
2010-09-23 13:37 ` Lars Magne Ingebrigtsen
2010-09-23 14:13 ` Eli Zaretskii
2010-09-23 14:21 ` Lars Magne Ingebrigtsen
2010-09-23 14:31 ` Lars Magne Ingebrigtsen
2010-09-23 14:41 ` Eli Zaretskii
2010-09-23 14:49 ` Lars Magne Ingebrigtsen
2010-09-23 15:08 ` Lars Magne Ingebrigtsen
2010-09-23 18:56 ` Eli Zaretskii
2010-09-23 19:02 ` Lars Magne Ingebrigtsen
2010-09-23 19:22 ` Eli Zaretskii
2010-09-24 14:09 ` Richard Stallman
2010-09-24 14:28 ` Eli Zaretskii
2010-09-24 14:38 ` Lars Magne Ingebrigtsen
2010-09-25 13:55 ` Eli Zaretskii
2010-09-25 16:26 ` Lars Magne Ingebrigtsen
2010-09-25 16:38 ` Lars Magne Ingebrigtsen
2010-09-25 9:40 ` Richard Stallman
2010-09-25 10:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkv8mwmv.fsf@hase.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).