unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Reversion of change #107149.
@ 2012-02-22 19:42 Alan Mackenzie
  2012-02-22 20:31 ` Stefan Monnier
  2012-02-22 22:08 ` Lars Magne Ingebrigtsen
  0 siblings, 2 replies; 3+ messages in thread
From: Alan Mackenzie @ 2012-02-22 19:42 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

As maintainer of CC Mode, I have reverted change #107149.  It wasn't
convincing.

I suggest you amend mm-display-inline-fontify accordingly.

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Reversion of change #107149.
  2012-02-22 19:42 Reversion of change #107149 Alan Mackenzie
@ 2012-02-22 20:31 ` Stefan Monnier
  2012-02-22 22:08 ` Lars Magne Ingebrigtsen
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2012-02-22 20:31 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: Lars Ingebrigtsen, emacs-devel

> As maintainer of CC Mode, I have reverted change #107149.  It wasn't
> convincing.
> I suggest you amend mm-display-inline-fontify accordingly.

FWIW, I agree that mm-display-inline-fontify should be more careful, but
I also think that CC-mode should also be more careful (i.e. avoid using
font-lock-mode-hook).
Shouldn't it be sufficient to (require 'font-lock) in cc-mode.el or
something along these lines?


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Reversion of change #107149.
  2012-02-22 19:42 Reversion of change #107149 Alan Mackenzie
  2012-02-22 20:31 ` Stefan Monnier
@ 2012-02-22 22:08 ` Lars Magne Ingebrigtsen
  1 sibling, 0 replies; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-02-22 22:08 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: emacs-devel

Alan Mackenzie <acm@muc.de> writes:

> As maintainer of CC Mode, I have reverted change #107149.  It wasn't
> convincing.
>
> I suggest you amend mm-display-inline-fontify accordingly.

You refused to explain why the code was the way it is (and since it's
obviously and patently ridiculous code, I can see why), so be my guest.

I'll guess I'll just slap an `ignore-errors' around the font-locking
call, and people won't get their .c files fontified nicely.  Whatevs.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-22 22:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-22 19:42 Reversion of change #107149 Alan Mackenzie
2012-02-22 20:31 ` Stefan Monnier
2012-02-22 22:08 ` Lars Magne Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).