From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: hexl Date: Fri, 17 May 2019 14:45:23 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="47749"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 14:45:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRcF0-000CE2-Nl for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 14:45:38 +0200 Original-Received: from localhost ([127.0.0.1]:48103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcEz-0004B8-AK for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 08:45:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcEt-0004B3-3P for emacs-devel@gnu.org; Fri, 17 May 2019 08:45:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRcEr-0000qn-T3 for emacs-devel@gnu.org; Fri, 17 May 2019 08:45:31 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:34512) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRcEr-0000nT-5n for emacs-devel@gnu.org; Fri, 17 May 2019 08:45:29 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRcEm-0002vE-4L for emacs-devel@gnu.org; Fri, 17 May 2019 14:45:26 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWpm356Wj16Lh58RS0D AgIOCQlXGRRYnXIxAAACVElEQVQ4jXWUwY6kIBCGizbdZ0oyngXSnIFKfAKd88z24nnUyPs/whai k01mt6KR8PEXxQ8I6T8B47+jgGne2tVqzC6XSPzuFdhwswrAKEOGQ8fYVbAEoZUHE00NK06wIXiE G/fY0r96qGBcAlAPjbFVEgAuhefR0JQJmEUP2I0Tg/fFNwxEBbbnVgULqtb0AMTYktGsHU6AGBDA N2QjGQBU3TfACrhiW8Awlck3RCqAOCxpCW3sDsAKKqmi8dFw3YDtBRQDCexItAxEOFNxVwUWW8tf gdgdtqOogCvQir83BkUxnQoeiJaL8DcKw2HJFyguzBeF0gikVKheLVJl/E7FCgziAJ+oNna0pOIF SX9TJ+Bys6ygtcorQVakv0BJRRRpFVlUwBbOUEFAkiosF1DbpWh1DCp8nSCleQ5FIiV21P2K/Qk+ cQvY8ezQmWGNkQ/DBXAvkvuLFA1lKbKCF257UMcCW9dZbjUVzOVczgy4RxN1H/JM9cq5mAsoMITg spTn5DOnPqpCiC5pKy/FnJfiIcAD8QWyzPGolpB/BH+ADiWqTxBvDKZRZmhyMeUtdZjc/qFvFfgd 7qmA+7inxI9u3WXJPmcGrXuOk9nTuuYTpJkbfLAY5H1Kq/kGv/mscjQp3VwejKnlTnx3tqHUm1eX Vu1WAxeYclc2d89unY1rz63lbr0naNkQfFs3o9v+BLOhVwMtb4N/5N64tW9OxUjzEwUBBE/HDXke QLvd7kk1RLyJwLdOiLrAORnzfOdb4wVnYwzKnal4JeOPv0/6+eeZysg/xgfLfevm13MAAAAASUVO RK5CYII= In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 17 May 2019 04:15:46 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236662 Archived-At: In hexl-insert-multibyte-char: hexl.el:881:29:Warning: =E2=80=98string-as-unibyte=E2=80=99 is an obsolete = function (as of 26.1); use =E2=80=98encode-coding-string=E2=80=99. This is the code... (let ((encoded (encode-coding-char ch coding)) (internal (string-as-unibyte (char-to-string ch))) internal-hex) ;; If encode-coding-char returns nil, it means our character ;; cannot be safely encoded with buffer-file-coding-system. ;; In that case, we offer to insert the internal representation ;; of that character, byte by byte. And here we really, really want the internal byte representation of the multibyte string, so I think the code is correct and just needs a with-no-warnings? I mean, (with-suppressed-warnings ((obsolete string-as-unibyte)) (string-as-unibyte (char-to-string ch))) :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no