From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: tags Date: Wed, 19 Jun 2019 15:18:49 +0200 Message-ID: References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="96321"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 19 15:19:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdaVF-000OuZ-FC for ged-emacs-devel@m.gmane.org; Wed, 19 Jun 2019 15:19:53 +0200 Original-Received: from localhost ([::1]:38234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdaVE-0001fw-HB for ged-emacs-devel@m.gmane.org; Wed, 19 Jun 2019 09:19:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39439) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdaUM-0001cn-1x for emacs-devel@gnu.org; Wed, 19 Jun 2019 09:18:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdaUK-0003w8-4M for emacs-devel@gnu.org; Wed, 19 Jun 2019 09:18:57 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdaUI-0003tx-Po for emacs-devel@gnu.org; Wed, 19 Jun 2019 09:18:56 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdaUD-0002X8-Uj; Wed, 19 Jun 2019 15:18:52 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUAAACyjXMODQ0AAQIA AAHlwZxQPjjNp4QBAQH97soDBAUBAgMlHhw6MS1pUkeJalz6JZxlAAABQ0lEQVQ4jWNgQAMcHA1g ElW0AV0ZmiYwuQBNtAEmsQObDpA9WI3lwCYIEm/A4RAOHK7jxmEQThvIBDiN68Yl0YWki6NrBXZT EysDH2GzRy9SMvDZEUwZpnpJ0dpndzAtbwv9KS6b+0cBw4rzot//XbubLgExowEuzvL+37u7b85H BkH58IBk+XcnLTdPdKoMlM8M1/LmWeKl56GltSguBTH03l+7Jh5eGgY1aQc8BvW/nUn8FzpzDsxo uFFn7t4V/1c5cxaqr4Fgzdm35fKRM59g+IPp7rHSwsqJCzAkGJR0JcMlhdANAgIu3cSpZVg0AGWU 7iDEcUYtFZMQTqNYcEkw45LwwpIXwMZb4bJ7F46s3b0KLIFp2u5VDF27FyxAd3QDSGIB1iTPvQtD CGpsN8MGZEcimN0M2g1ISqEGcHR07wIAqZFYvxMCaU0AAAAASUVORK5CYII= In-Reply-To: (Dmitry Gutov's message of "Tue, 18 Jun 2019 16:44:17 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237890 Archived-At: Dmitry Gutov writes: >>> Should we just remove the command and the custom >>> binding? Not sure if eshell-mode just set up xref-find-functions as >>> well. Is it supposed to use a tags table, or find-func.el? >> >> I can't see any mention of xref in the eshell files... > > Sorry, I meant: Not sure if eshell-mode *should* set up > xref-find-functions as well. If it should, how does it do that? >>> As for viper, I guess the emulation stuff has some UI requrements? >>> Otherwise we could use xref-find-definitions and >>> xref-find-definitions-other-window there. >> >> The latter is fine, but the call for find-tag is with the next-p parameter: >> >> (if (string= tag "") >> (find-tag ex-tag t) >> (find-tag-other-window ex-tag)) >> >> How is that done in terms of xref? > > But what does NEXT-P mean in this context? It's not like there has > been a previous invocation of find-tag, was there? It seems like the logic is that the first time the function is called, find-tag-other-window, and the next one it's calling find-tag with NEXT-P? > BTW, your last change in this function is clearly inadequate: find-tag > and xref-find-definitions-other-window present different UIs when > there's more locations than one. We shouldn't use both in the same > command. Ah; I'll revert that patch, then. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no