unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Madhu <enometh@meer.net>
To: emacs-devel@gnu.org
Subject: Re: emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests
Date: Tue, 06 Aug 2024 08:11:33 +0530	[thread overview]
Message-ID: <m3y15a9xuq.fsf@leonis4.robolove.meer.net> (raw)
In-Reply-To: 87cymmomol.fsf@gmx.de

* Michael Albinus <87cymmomol.fsf@gmx.de> :
Wrote on Mon, 05 Aug 2024 20:21:30 +0200:
> Michael Albinus <michael.albinus@gmx.de> writes:
>>>> +		   :result ,(substring-no-properties
>>>> +			     (file-remote-p "/sudo::/tmp/foo" 'user)))
>>>
>>> just a caveat that substring-no-properties can end up being called on
>>> nil here.  I agree it is unlikely, but I managed to trigger it with the
>>> `swiper' package, where an unconditional (require 'tramp) in the midst
>>> of code kept failing.
>>
>> In that case (file-remote-p returns nil) the whole block doesn't make
>> sense. How did they manage to manipulate Tramp this way? Setting
>> tramp-mode to nil? Manipulating file-name-handler-alist?

It wasn't them, it was me, or I suspect it was some async (delayed
loading/reloading) glitch but I'm not sure how it happened.  AFAIK i was
not using the hammer on file-name-handler-alist [1], all I did was set
tramp-completion-file-name-handler-alist to nil.

> I've added a sanity check. Pushed to the emacs-30 branch.
Thanks

[1] a decade ago I used to disable tramp with this hammer, but it too
was ineffective when tramp got (somehow) reloaded so I abandoned it. I'm
pretty sure I had not manipulated this explicitly to trigger this crash.

```
(setq file-name-handler-alist
      (loop for x in file-name-handler-alist
	    for (pattern . symbol) = x
	    for name = (symbol-name symbol)
	    unless (string-match "tramp" name) collect x))
```




  reply	other threads:[~2024-08-06  2:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <172163502862.25672.12565431460737995012@vcs2.savannah.gnu.org>
     [not found] ` <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org>
2024-08-05 14:30   ` emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests Madhu
2024-08-05 16:57     ` Michael Albinus
2024-08-05 18:21       ` Michael Albinus
2024-08-06  2:41         ` Madhu [this message]
2024-08-06 14:08           ` Michael Albinus
2024-08-07 15:21             ` Madhu
2024-09-25 16:08   ` Andreas Schwab
2024-09-25 17:47     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y15a9xuq.fsf@leonis4.robolove.meer.net \
    --to=enometh@meer.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).