unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: Lars Hansen <larsh@soem.dk>, emacs-devel@gnu.org
Subject: Re: minibuffer and scroll-conservatively
Date: Mon, 27 Jun 2005 12:29:08 +0200	[thread overview]
Message-ID: <m3wtogqeiz.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <E1DmP26-0006qL-T3@fencepost.gnu.org> (Richard M. Stallman's message of "Sun, 26 Jun 2005 00:46:14 -0400")

"Richard M. Stallman" <rms@gnu.org> writes:

>     Start todays emacs with -Q and set scroll-conservatively to some
>     non-zero number, say 1.
>     Then type eg. M-x  ABC. Now the minibuffer shows "M-x ABC" as expected.
>     But if you type the Danish character A-ring (a capital A with a ring
>     above) everything seems to disappear from the minibuffer.
>
> I tried this under X, using the Emacs input method Latin-1-Postfix to
> insert the Å, and the failure happened.  What occurred was that the
> minibuffer contents all scrolled off the top of the window.
>
> I think the reason for this is that the Å character is taller than
> ordinary letters; taller, in fact, than the height of the window.
> I think this confuses scrolling calculations so that they believe
> that character doesn't fit on the screen while allowing point
> to be visible.
>
> Kim, could you investigate this and fix it?

Can you try this patch, to see if the result is acceptable...

There are still problems: If I enter M-x ABÅjg, the result is not
perfect -- but what's the alternative?


*** xdisp.c	26 Jun 2005 23:25:32 +0200	1.1028
--- xdisp.c	27 Jun 2005 12:24:09 +0200	
***************
*** 11294,11300 ****
    window_height = window_box_height (w);
    if (row->height >= window_height)
      {
!       if (!force_p || w->vscroll)
  	return 1;
      }
    return 0;
--- 11294,11300 ----
    window_height = window_box_height (w);
    if (row->height >= window_height)
      {
!       if (!force_p || MINI_WINDOW_P (w) || w->vscroll)
  	return 1;
      }
    return 0;
***************
*** 12729,12735 ****
      }
  
    /* Don't let the cursor end in the scroll margins.  */
!   if (check_margins)
      {
        int this_scroll_margin, cursor_height;
  
--- 12729,12736 ----
      }
  
    /* Don't let the cursor end in the scroll margins.  */
!   if (check_margins
!       && !MINI_WINDOW_P (w))
      {
        int this_scroll_margin, cursor_height;

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2005-06-27 10:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-21 15:47 minibuffer and scroll-conservatively Lars Hansen
2005-06-21 16:39 ` Gaëtan LEURENT
2005-06-26  4:46 ` Richard M. Stallman
2005-06-27 10:29   ` Kim F. Storm [this message]
2005-06-28  4:16     ` Richard M. Stallman
2005-06-28  8:52       ` Kim F. Storm
2005-06-28 10:00         ` Lars Hansen
2005-07-13  7:25           ` Lars Hansen
2005-07-13 10:30             ` Kim F. Storm
2005-06-29  3:58         ` Richard M. Stallman
2005-06-29  4:48         ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wtogqeiz.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    --cc=larsh@soem.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).