Re: EMACS_INT cleanup

[Lars Magne Ingebrigtsen <larsi@gnus.org>]

Eli Zaretskii <eliz@gnu.org> writes:

>> since -Wall is in the state it's in, I was assuming that there might
>> be a reason for that state.
>
> Lazyness^H^H^H^H^H^Hck of time?

Right.  :-)

I'll continue the -Wconversion trolling in the Emacs sources, and fix
all the long->int conversions I find, no matter how unlikely it is to
appear in real life, then.

But probably not tonight.

If somebody else wants to join in, feel free.  They methodology I'm
using is the following:

1) First I say "make" as normal in the src directly.

2) Then I alter the warnings switch to add -Wconversion:

C_WARNINGS_SWITCH = -Wimplicit-function-declaration -Wold-style-definition -Wdeclaration-after-statement -Wno-pointer-sign -Wconversion

3) Then I pick a file -- for instance, fns.c.  Then I force-save it to
update the time stamp.

4) Then I hit F7, which I have bound to:

(global-set-key
 [f7] (lambda () (interactive)
	(save-some-buffers t)
        (ignore-errors
	  (mapcar (lambda (proc) (kill-process proc))
		  compilation-in-progress))
	(setq compilation-in-progress nil)
	(compile "make -k 2>&1 | egrep \"(conversion.*'int'.*(Lisp_Obj|long)|error)\"")))

So then it's only a case of next-erroring to each error and fix stuff.

Anyone can do it!  :-)

(If they have gcc 4.4.)
        
-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen