Re: trunk r115246: eww usability improvements

Re: trunk r115246: eww usability improvements

[Lars Magne Ingebrigtsen]

Teodor Zlatanov <tzz@lifelogs.com> writes:

> +  (if (y-or-n-p "quit eww? ")
> +      (progn
> +	(setq eww-history nil)
> +	(kill-buffer (current-buffer)))))

I'm not sure that's a good change.  The normal use case for eww is to
use it to browse a page or two, and then you want it to go away.  Which
`q' does.  Querying whether to do so isn't what most Emacs special modes
do with that command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Thu, 28 Nov 2013 19:43:43 +0100 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Teodor Zlatanov <tzz@lifelogs.com> writes:
>> +  (if (y-or-n-p "quit eww? ")
>> +      (progn
>> +	(setq eww-history nil)
>> +	(kill-buffer (current-buffer)))))

LMI> I'm not sure that's a good change.  The normal use case for eww is to
LMI> use it to browse a page or two, and then you want it to go away.  Which
LMI> `q' does.  Querying whether to do so isn't what most Emacs special modes
LMI> do with that command.

Gnus behaves similarly by default so I thought it was reasonable
behavior.  It is annoying to hit `q' accidentally.  What do you think
about `Q' for quitting immediately and maybe a `eww-expert-mode' to
remove all prompts?

Ted

Re: trunk r115246: eww usability improvements

[Stefan Monnier]

> Gnus behaves similarly by default so I thought it was reasonable
> behavior.  It is annoying to hit `q' accidentally.

I think `q' should just use the standard binding from special-mode.


        Stefan

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Fri, 29 Nov 2013 12:05:08 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>> Gnus behaves similarly by default so I thought it was reasonable
>> behavior.  It is annoying to hit `q' accidentally.

SM> I think `q' should just use the standard binding from special-mode.

But eww is a stateful application, not just a special mode.

Ted

Re: trunk r115246: eww usability improvements

[Stefan Monnier]

> But eww is a stateful application,

I don't see why that makes a difference.


        Stefan

Re: trunk r115246: eww usability improvements

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> But eww is a stateful application,
>
> I don't see why that makes a difference.

It makes a difference for stuff that's extremely stateful (like Gnus),
but eww isn't in that category.  eww is more like dired.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: trunk r115246: eww usability improvements

[T.V. Raman]

Would be far simpler to let 'q' bury-buffer -- gets it out of the
way, and it's easy enough to jump back.

-- 
Best Regards,
--raman


On 11/29/13, Ted Zlatanov <tzz@lifelogs.com> wrote:
> On Thu, 28 Nov 2013 19:43:43 +0100 Lars Magne Ingebrigtsen <larsi@gnus.org>
> wrote:
>
> LMI> Teodor Zlatanov <tzz@lifelogs.com> writes:
>>> +  (if (y-or-n-p "quit eww? ")
>>> +      (progn
>>> +	(setq eww-history nil)
>>> +	(kill-buffer (current-buffer)))))
>
> LMI> I'm not sure that's a good change.  The normal use case for eww is to
> LMI> use it to browse a page or two, and then you want it to go away.
> Which
> LMI> `q' does.  Querying whether to do so isn't what most Emacs special
> modes
> LMI> do with that command.
>
> Gnus behaves similarly by default so I thought it was reasonable
> behavior.  It is annoying to hit `q' accidentally.  What do you think
> about `Q' for quitting immediately and maybe a `eww-expert-mode' to
> remove all prompts?
>
> Ted
>
>

Re: trunk r115246: eww usability improvements

[Lars Magne Ingebrigtsen]

"T.V. Raman" <tv.raman.tv@gmail.com> writes:

> Would be far simpler to let 'q' bury-buffer -- gets it out of the
> way, and it's easy enough to jump back.

True.  I've now bound `q' to `quit-window'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Sun, 01 Dec 2013 18:00:28 +0100 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> "T.V. Raman" <tv.raman.tv@gmail.com> writes:
>> Would be far simpler to let 'q' bury-buffer -- gets it out of the
>> way, and it's easy enough to jump back.

LMI> True.  I've now bound `q' to `quit-window'.

Thanks for doing this, I got pulled away and couldn't get to it.

I think `quit-window' is the right behavior.

Ted

Re: trunk r115246: eww usability improvements

[T.V. Raman]

Another useful twist might be to name the *eww* buffer with the
title of the page, and allow the user to invoke new, separate
instances with a prefix arg to eww.

-- 
Best Regards,
--raman


On 12/4/13, Ted Zlatanov <tzz@lifelogs.com> wrote:
> On Sun, 01 Dec 2013 18:00:28 +0100 Lars Magne Ingebrigtsen <larsi@gnus.org>
> wrote:
>
> LMI> "T.V. Raman" <tv.raman.tv@gmail.com> writes:
>>> Would be far simpler to let 'q' bury-buffer -- gets it out of the
>>> way, and it's easy enough to jump back.
>
> LMI> True.  I've now bound `q' to `quit-window'.
>
> Thanks for doing this, I got pulled away and couldn't get to it.
>
> I think `quit-window' is the right behavior.
>
> Ted
>
>
>

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Wed, 4 Dec 2013 19:35:37 -0800 "T.V. Raman" <tv.raman.tv@gmail.com> wrote: 

TVR> Another useful twist might be to name the *eww* buffer with the
TVR> title of the page, and allow the user to invoke new, separate
TVR> instances with a prefix arg to eww.

I would even make "always browse in a new buffer" the default behavior
for `M-x eww' (but following links should update the current buffer).

This the UI most web browsers implement: "new window or tab" for a new
URL, but stay in the current window or tab when following links.

Ted

Re: trunk r115246: eww usability improvements

[T.V. Raman]

that would work for me too. Also, I was expecting eww to be
significantly faster than   emacs/w3 given that the parsing is
happening in C.  At present, emacs/w3 is still beating out eww,
might be worth seeing if it can be sped up.
-- 

-- 


On 12/5/13, Ted Zlatanov <tzz@lifelogs.com> wrote:
> On Wed, 4 Dec 2013 19:35:37 -0800 "T.V. Raman" <tv.raman.tv@gmail.com>
> wrote:
>
> TVR> Another useful twist might be to name the *eww* buffer with the
> TVR> title of the page, and allow the user to invoke new, separate
> TVR> instances with a prefix arg to eww.
>
> I would even make "always browse in a new buffer" the default behavior
> for `M-x eww' (but following links should update the current buffer).
>
> This the UI most web browsers implement: "new window or tab" for a new
> URL, but stay in the current window or tab when following links.
>
> Ted
>

Re: trunk r115246: eww usability improvements

[Nakayama Kenjiro]

[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]

> True.  I've now bound `q' to `quit-window'.

Then,  please apply this one, too.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
`quit-window'
        instead of killing the buffer.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 9d1c3a2..1368912 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."

     (easy-menu-define nil map ""
       '("Eww"
-       ["Quit" eww-quit t]
+       ["Quit" quit-window t]
        ["Reload" eww-reload t]
        ["Back to previous page" eww-back-url
         :active (not (zerop (length eww-history)))]
-- 
1.8.3.1



Kenjiro Nakayama



On Mon, Dec 2, 2013 at 2:00 AM, Lars Magne Ingebrigtsen <larsi@gnus.org>wrote:

> "T.V. Raman" <tv.raman.tv@gmail.com> writes:
>
> > Would be far simpler to let 'q' bury-buffer -- gets it out of the
> > way, and it's easy enough to jump back.
>
> True.  I've now bound `q' to `quit-window'.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>
>

[-- Attachment #2: Type: text/html, Size: 2107 bytes --]

Re: trunk r115246: eww usability improvements

[Nakayama Kenjiro]

[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]

I found another tiny mistake in easy-menu. I resend the fixes.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
`quit-window' instead of killing the buffer. And fixed wrong function of
"List bookmarks".

---
 lisp/net/eww.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 9d1c3a2..0c6513e 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."

     (easy-menu-define nil map ""
       '("Eww"
-       ["Quit" eww-quit t]
+       ["Quit" quit-window t]
        ["Reload" eww-reload t]
        ["Back to previous page" eww-back-url
         :active (not (zerop (length eww-history)))]
@@ -429,7 +429,7 @@ word(s) will be searched for via `eww-search-prefix'."
        ["View page source" eww-view-source]
        ["Copy page URL" eww-copy-page-url t]
        ["Add bookmark" eww-add-bookmark t]
-       ["List bookmarks" eww-copy-page-url t]
+       ["List bookmarks" eww-list-bookmarks t]
        ["List cookies" url-cookie-list t]))
     map))

-- 
1.8.3.1




On Sun, Dec 8, 2013 at 11:40 AM, Nakayama Kenjiro <nakayamakenjiro@gmail.com
> wrote:

> > True.  I've now bound `q' to `quit-window'.
>
> Then,  please apply this one, too.
>
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
>         * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
> `quit-window'
>         instead of killing the buffer.
>
> ---
>  lisp/net/eww.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 9d1c3a2..1368912 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."
>
>      (easy-menu-define nil map ""
>        '("Eww"
> -       ["Quit" eww-quit t]
> +       ["Quit" quit-window t]
>         ["Reload" eww-reload t]
>         ["Back to previous page" eww-back-url
>          :active (not (zerop (length eww-history)))]
> --
> 1.8.3.1
>
>
>
> Kenjiro Nakayama
>
>
>
>
> On Mon, Dec 2, 2013 at 2:00 AM, Lars Magne Ingebrigtsen <larsi@gnus.org>wrote:
>
>> "T.V. Raman" <tv.raman.tv@gmail.com> writes:
>>
>> > Would be far simpler to let 'q' bury-buffer -- gets it out of the
>> > way, and it's easy enough to jump back.
>>
>> True.  I've now bound `q' to `quit-window'.
>>
>> --
>> (domestic pets only, the antidote for overdose, milk.)
>>    bloggy blog: http://lars.ingebrigtsen.no
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 4188 bytes --]

Re: trunk r115246: eww usability improvements

[Kenjiro NAKAYAMA]

Sorry, I have One more thing. if we use quit-window to quit eww, the following two lines in
eww-mode-map should be deleted? After restart eww, we can use the eww-history.

(set (make-local-variable 'eww-history) nil)
(set (make-local-variable 'eww-history-position) 0)

I sent the patch with the new function to list the browser histories
to bug-gnu-emacs mailing list (bug#16086).

Kenjiro NAKAYAMA

nakayamakenjiro@gmail.com writes:

> I found another tiny mistake in easy-menu. I resend the fixes.
>
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
>         * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
> `quit-window' instead of killing the buffer. And fixed wrong function of
> "List bookmarks".
>
> ---
>  lisp/net/eww.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 9d1c3a2..0c6513e 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."
>
>      (easy-menu-define nil map ""
>        '("Eww"
> -       ["Quit" eww-quit t]
> +       ["Quit" quit-window t]
>         ["Reload" eww-reload t]
>         ["Back to previous page" eww-back-url
>          :active (not (zerop (length eww-history)))]
> @@ -429,7 +429,7 @@ word(s) will be searched for via `eww-search-prefix'."
>         ["View page source" eww-view-source]
>         ["Copy page URL" eww-copy-page-url t]
>         ["Add bookmark" eww-add-bookmark t]
> -       ["List bookmarks" eww-copy-page-url t]
> +       ["List bookmarks" eww-list-bookmarks t]
>         ["List cookies" url-cookie-list t]))
>      map))

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Sun, 8 Dec 2013 12:03:57 +0900 Nakayama Kenjiro <nakayamakenjiro@gmail.com> wrote: 

NK> I found another tiny mistake in easy-menu. I resend the fixes.
NK> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

NK>         * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
NK> `quit-window' instead of killing the buffer. And fixed wrong function of
NK> "List bookmarks".

I made the change, thank you.  One tiny difference: I used "Exit" for
`eww-quit' (which, btw, could be renamed accordingly) and "Close
browser" for `quit-window'.

Ted

Re: trunk r115246: eww usability improvements

[nakayamakenjiro]

tzz@lifelogs.com writes:

Ted> I made the change, thank you.  One tiny difference: I used "Exit" for
Ted> `eww-quit' (which, btw, could be renamed accordingly) and "Close

defun eww-quit() has already been deleted, hasn't it? 

http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/net/eww.el?id=4c004eaa87a1c9771a3ad07b382efbb81e380f96


tzz@lifelogs.com writes:

> On Sun, 8 Dec 2013 12:03:57 +0900 Nakayama Kenjiro <nakayamakenjiro@gmail.com> wrote: 
>
> NK> I found another tiny mistake in easy-menu. I resend the fixes.
> NK> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> NK>         * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a
> NK> `quit-window' instead of killing the buffer. And fixed wrong function of
> NK> "List bookmarks".
>
> I made the change, thank you.  One tiny difference: I used "Exit" for
> `eww-quit' (which, btw, could be renamed accordingly) and "Close
> browser" for `quit-window'.
>
> Ted

Re: trunk r115246: eww usability improvements

[Ted Zlatanov]

On Wed, 11 Dec 2013 14:00:31 +0900 <nakayamakenjiro@gmail.com> wrote: 

> tzz@lifelogs.com writes:
Ted> I made the change, thank you.  One tiny difference: I used "Exit" for
Ted> `eww-quit' (which, btw, could be renamed accordingly) and "Close

> defun eww-quit() has already been deleted, hasn't it? 

> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/net/eww.el?id=4c004eaa87a1c9771a3ad07b382efbb81e380f96

Right.  I pushed a followup that introduces `eww-close' and `eww-exit'
(the latter used to be `eww-quit').

Thanks
Ted