From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP
Date: Sun, 13 Mar 2016 14:09:39 -0400 [thread overview]
Message-ID: <m3wpp6w8po.fsf@fitzsim.org> (raw)
In-Reply-To: <jwvfuvu5s6x.fsf-monnier+Inbox@gnu.org> (Stefan Monnier's message of "Sun, 13 Mar 2016 11:15:23 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> The interface does not return bytes, it returns a (half-)decoded lisp
>>>> form.
>>> My understanding is that it returns a structure whose leaves are
>>> all byte-strings because.
>> String values are returned as multibyte, e.g.:
>> (multibyte-string-p (cdr (assq 'severity (car (debbugs-get-status 22285)))))
>> => t
>> because parsing happens in a temporary buffer where
>> enable-multibyte-characters is set, and the string value is returned
>> unchanged.
>
> If these are undecoded, then I'd consider it a bug to return them as
> multibyte, indeed. The temp buffer should probably be made unibyte.
See my response to Eli.
>> this nuance of the API. Also, on the encoding side I think we should
>> force the caller to provide unibyte strings for base64Binary values.
>
> I'd let base64-encode-string make that decision, but it's just my own
> preference of bikeshed's color.
OK.
>> Is the attached patch OK for master and emacs-25?
>
> Looks OK to me for master. I'll let others figure out if it's safe
> enough for `emacs-25'.
Andreas committed his change to base64Binary handling to both master and
emacs-25. Whatever the decision regarding reverting it, those two
branches should have the same behavior.
Thomas
next prev parent reply other threads:[~2016-03-13 18:09 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160106200404.17375.71733@vcs.savannah.gnu.org>
[not found] ` <E1aGuJQ-0004Wv-Lz@vcs.savannah.gnu.org>
2016-03-10 1:03 ` emacs-25 b6b47af: Properly encode/decode base64Binary data in SOAP Thomas Fitzsimmons
2016-03-10 9:30 ` Andreas Schwab
2016-03-11 3:29 ` emacs-25 b6b47AF: " Thomas Fitzsimmons
2016-03-11 8:35 ` Andreas Schwab
2016-03-11 13:49 ` Alex Harsanyi
2016-03-11 14:09 ` Andreas Schwab
2016-03-11 16:48 ` Stefan Monnier
2016-03-11 16:59 ` Andreas Schwab
2016-03-11 22:27 ` Stefan Monnier
2016-03-13 3:52 ` Thomas Fitzsimmons
2016-03-13 15:15 ` Stefan Monnier
2016-03-13 18:09 ` Thomas Fitzsimmons [this message]
2016-03-13 16:02 ` Eli Zaretskii
2016-03-13 17:57 ` Thomas Fitzsimmons
2016-03-13 18:30 ` Eli Zaretskii
2016-03-13 19:54 ` Thomas Fitzsimmons
2016-03-13 20:19 ` Eli Zaretskii
2016-03-13 21:17 ` Thomas Fitzsimmons
2016-03-14 3:30 ` Eli Zaretskii
2016-03-14 8:49 ` Andreas Schwab
2016-03-14 9:15 ` Michael Albinus
2016-03-14 11:56 ` Stefan Monnier
2016-03-14 12:18 ` Alex Harsanyi
2016-03-14 11:58 ` Alex Harsanyi
2016-03-14 12:38 ` Michael Albinus
2016-03-14 13:18 ` Alex Harsanyi
2016-03-14 13:30 ` Michael Albinus
2016-03-14 13:26 ` Stefan Monnier
2016-03-14 14:12 ` Michael Albinus
2016-03-14 14:58 ` Thomas Fitzsimmons
2016-03-14 15:56 ` Michael Albinus
2016-03-14 17:58 ` Eli Zaretskii
2016-03-15 1:56 ` Thomas Fitzsimmons
2016-03-15 7:45 ` Andreas Schwab
2016-03-15 7:57 ` Michael Albinus
2016-03-15 7:49 ` Andreas Schwab
2016-03-15 8:08 ` Michael Albinus
2016-03-15 14:39 ` Thomas Fitzsimmons
2016-03-15 15:04 ` Michael Albinus
2016-03-17 14:23 ` Thomas Fitzsimmons
2016-03-17 15:39 ` Thomas Fitzsimmons
2016-03-17 19:24 ` Michael Albinus
2016-03-17 15:46 ` Stefan Monnier
2016-03-15 17:39 ` Eli Zaretskii
2016-03-14 17:53 ` Eli Zaretskii
2016-03-14 18:47 ` Michael Albinus
2016-03-14 18:57 ` Eli Zaretskii
2016-03-14 17:49 ` Eli Zaretskii
2016-03-14 18:44 ` Michael Albinus
2016-03-14 18:52 ` Eli Zaretskii
2016-03-14 19:05 ` Michael Albinus
2016-03-14 9:23 ` Thomas Fitzsimmons
2016-03-14 9:58 ` Andreas Schwab
2016-03-14 8:02 ` Michael Albinus
2016-03-14 12:39 ` Stefan Monnier
2016-03-14 17:55 ` Eli Zaretskii
2016-03-14 17:48 ` Eli Zaretskii
2016-03-14 18:42 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wpp6w8po.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).