From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: erc.el Date: Thu, 13 Jun 2019 02:04:07 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54113"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 02:04:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbDEZ-000Dwx-Qz for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 02:04:51 +0200 Original-Received: from localhost ([::1]:36248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbDEY-0000dc-7I for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2019 20:04:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43771) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbDDy-0000dW-QO for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:04:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbDDx-0004u4-4R for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:04:14 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:41928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbDDw-0004te-Ru for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:04:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbDDr-0002eS-KQ for emacs-devel@gnu.org; Thu, 13 Jun 2019 02:04:10 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUIAwcLBQsPBgsOCA3o 4uZHOzSdko8PBw0FAQYcFRIy+KLmAAACSElEQVQ4jWXTsW7bMBAG4FO8OJsYIkO2OEYHb2WItNXO 6AUUCuAuCvBYeCiyqciiMbZAA3zb/kdKiYMeDNjmJ/4kjxC9hd67GFvjI1eLP6F3caIREDe7F+N/ jeO4av2RAGWRwD1WnfHvCeoTAwHOfe8enzrz/L4eh9VLfSqC4RlD2/VOL3D9UjdXwewBf1tTOx2M qU/rga470xRns1eC3j6BKEH5CfvpDGgAu87sb87GK0nXAM9gmjxj/3g2zww9IDI4wLcvgEO3gD0N DH6G2wsgemJA+FHS0wf47wmeT4ApQ+8SKKLQYdsMd2gMwCZ4p4JhAjQVoANAkUFXDM0CZoZ6KiUf 1P0HzebqAnis9wncZnsB7QU8zNDVLkPdMxh/2mJ3tV0Au0rlJxwQ1wbwDF2Kwri7JypiC+hdht56 mycQbUOwIerIu+qNtyiniYTYBmejVpUmvtU+WhuPohRCFKEJVmilaVy5qG69FWIl5pJCaACCix++ KREklUqCqYBxIGrtUc2Pl4IfYVjzlLwAh6BILlE0P63l8oNhWK+LopxXnQPlsvickcZVmpBgwISU ptXyPMMJ79EuvU0HrS7XiB+1VVLpHMTwcF88bH7fvWox/akOP3X1qg8JgnXBWjQVFdFalxoKuIt4 aWPYuZzn0jeDKDfiJm9G4aN4AZmjUiGBh7iRKu+qmmKc9DTvH2NKygwxVhqUBjmOT5/PgV1FzsK9 5WZJ+dHdMv1NPVH56Evb+dLSGvPNzlAsHcISKrcXg1RmUHqu1N1/5SAtZkAfImYAAAAASUVORK5C YII= In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 13 Jun 2019 01:35:01 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237471 Archived-At: In erc-send-input: erc/erc.el:5462:9:Warning: global/dynamic var `str' lacks a prefix The problem here is that `str' is in the public calling converion on `erc-pre-send-hook': --- (defcustom erc-send-pre-hook nil "Hook called first when some text is sent through `erc-send-current-line'. It gets called with one argument, STRING. To change the text that will be sent, set the variable `str' which is used in `erc-send-current-line'. --- That's a quite, er, uhm, strange way of doing it, but... The traditional way is to offer a filter function that can alter the string. Would a way forward here be to obsolete this hook variable and add a new function along those lines? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no