From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: File modes facilities. Date: Mon, 24 Oct 2005 16:09:20 +0200 Message-ID: References: <87hdbdxo94.fsf@mahaena.lrde> <87d5m1qm8w.fsf-monnier+emacs@gnu.org> <877jc92o37.fsf@mahaena.lrde> <17238.50816.352274.312799@kahikatea.snap.net.nz> <87u0fd9let.fsf@mahaena.lrde> <87irvr3cu7.fsf@mahaena.lrde> <87d5lz3bna.fsf@mahaena.lrde> <87d5lver5p.fsf@mahaena.lrde> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1130163394 25449 80.91.229.2 (24 Oct 2005 14:16:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2005 14:16:34 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, eliz@gnu.org, snogglethorpe@gmail.com, miles@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 24 16:16:24 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EU36d-0003sF-Tn for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2005 16:15:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EU36c-0002ph-VC for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2005 10:15:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EU32c-0006sq-Ko for emacs-devel@gnu.org; Mon, 24 Oct 2005 10:11:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EU32a-0006qp-HQ for emacs-devel@gnu.org; Mon, 24 Oct 2005 10:11:09 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EU32a-0006qS-5L for emacs-devel@gnu.org; Mon, 24 Oct 2005 10:11:08 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EU31i-0002J0-Ti; Mon, 24 Oct 2005 10:10:15 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id 44CF05EE064; Mon, 24 Oct 2005 16:10:13 +0200 (CEST) Original-To: Michael Cadilhac In-Reply-To: <87d5lver5p.fsf@mahaena.lrde> (Michael Cadilhac's message of "Mon, 24 Oct 2005 01:42:58 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44720 Archived-At: Michael Cadilhac writes: > "Richard M. Stallman" writes: > >> There IS a function called set-file-modes. It is not interactive. My >> idea is to rename that to set-file-modes-internal, and use your chmod >> command under the name set-file-modes. It should accept a numeric >> mode argument too; that way, existing callers will still work. It >> would use file-modes-to-number. I still think my approach to make any command interactive is much, much better (and simpler) than this hotch-potch approach of renamingbuilt-in functions to COMMAND-internal and provide a wrapper in Lisp. BTW, I thought RMS said he didn't want to include this feature before the release!??!? That said, is it really safe to change the name of the file handler for set-file-modes? Will it break tramp and ange-ftp (and ???) > *************** > *** 3476,3484 **** > > /* If the file name has special constructs in it, > call the corresponding file handler. */ > ! handler = Ffind_file_name_handler (absname, Qset_file_modes); > if (!NILP (handler)) > ! return call3 (handler, Qset_file_modes, absname, mode); > > encoded_absname = ENCODE_FILE (absname); > > --- 3478,3486 ---- > > /* If the file name has special constructs in it, > call the corresponding file handler. */ > ! handler = Ffind_file_name_handler (absname, Qset_file_modes_internal); > if (!NILP (handler)) > ! return call3 (handler, Qset_file_modes_internal, absname, mode); > > encoded_absname = ENCODE_FILE (absname); -- Kim F. Storm http://www.cua.dk