From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] left-fringe for speedbar Date: Tue, 15 Nov 2005 00:08:35 +0100 Message-ID: References: <17270.27018.323474.12554@kahikatea.snap.net.nz> <17270.36100.39751.325250@kahikatea.snap.net.nz> <17272.61071.905030.333782@kahikatea.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1132009829 15535 80.91.229.2 (14 Nov 2005 23:10:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 Nov 2005 23:10:29 +0000 (UTC) Cc: miles@gnu.org, snogglethorpe@gmail.com, rms@gnu.org, drew.adams@oracle.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 15 00:10:23 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EbnSN-0003RF-Jr for ged-emacs-devel@m.gmane.org; Tue, 15 Nov 2005 00:09:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EbnSM-000602-PR for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2005 18:09:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EbnSB-0005zB-NH for emacs-devel@gnu.org; Mon, 14 Nov 2005 18:09:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EbnSB-0005yt-7U for emacs-devel@gnu.org; Mon, 14 Nov 2005 18:09:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EbnSB-0005yq-2O for emacs-devel@gnu.org; Mon, 14 Nov 2005 18:09:35 -0500 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EbnS9-00052Z-2x; Mon, 14 Nov 2005 18:09:33 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id 9976A47FE05; Tue, 15 Nov 2005 00:09:28 +0100 (CET) Original-To: Nick Roberts In-Reply-To: <17272.61071.905030.333782@kahikatea.snap.net.nz> (Nick Roberts's message of "Tue, 15 Nov 2005 09:07:43 +1300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45977 Archived-At: Nick Roberts writes: > So, I would still like to put the left fringe back. No-one complained about > it being there for the last four years and it makes things more consistent. > However, these issues become larger than they really should. I think it as an > insignificant change to the general user. If this problem is primarily observed with speedbar, the following patch seems to give good results without enabling left fringe in speedbar frame: *** gud.el 13 Nov 2005 21:04:40 +0100 1.69 --- gud.el 15 Nov 2005 00:07:12 +0100 *************** *** 122,127 **** --- 122,132 ---- (info "(emacs)GDB Graphical Interface") (info "(emacs)Debuggers")))) + (defun gud-tool-bar-item-visible-no-fringe () + (not (or (eq (buffer-local-value 'major-mode (window-buffer)) 'speedbar-mode) + (and (memq gud-minor-mode '(gdbmi gdba)) + (> (car (window-fringes)) 0))))) + (easy-mmode-defmap gud-menu-map '(([help] "Info" . gud-goto-info) ([tooltips] menu-item "Toggle GUD tooltips" gud-tooltip-mode *************** *** 136,154 **** ([until] menu-item "Continue to selection" gud-until :enable (and (not gud-running) (memq gud-minor-mode '(gdbmi gdba gdb perldb))) ! :visible (not (and (memq gud-minor-mode '(gdbmi gdba)) ! (> (car (window-fringes)) 0)))) ([remove] menu-item "Remove Breakpoint" gud-remove :enable (not gud-running) ! :visible (not (and (memq gud-minor-mode '(gdbmi gdba)) ! (> (car (window-fringes)) 0)))) ([tbreak] menu-item "Temporary Breakpoint" gud-tbreak :enable (memq gud-minor-mode '(gdbmi gdba gdb sdb xdb bashdb))) ([break] menu-item "Set Breakpoint" gud-break :enable (not gud-running) ! :visible (not (and (memq gud-minor-mode '(gdbmi gdba)) ! (> (car (window-fringes)) 0)))) ([up] menu-item "Up Stack" gud-up :enable (and (not gud-running) (memq gud-minor-mode --- 141,156 ---- ([until] menu-item "Continue to selection" gud-until :enable (and (not gud-running) (memq gud-minor-mode '(gdbmi gdba gdb perldb))) ! :visible (gud-tool-bar-item-visible-no-fringe)) ([remove] menu-item "Remove Breakpoint" gud-remove :enable (not gud-running) ! :visible (gud-tool-bar-item-visible-no-fringe)) ([tbreak] menu-item "Temporary Breakpoint" gud-tbreak :enable (memq gud-minor-mode '(gdbmi gdba gdb sdb xdb bashdb))) ([break] menu-item "Set Breakpoint" gud-break :enable (not gud-running) ! :visible (gud-tool-bar-item-visible-no-fringe)) ([up] menu-item "Up Stack" gud-up :enable (and (not gud-running) (memq gud-minor-mode -- Kim F. Storm http://www.cua.dk