From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix use of sockaddr_in Date: Sun, 14 May 2017 12:28:52 +0200 Message-ID: References: <83shk989r5.fsf@gnu.org> <20170513150837.31184-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494757765 8403 195.159.176.226 (14 May 2017 10:29:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 May 2017 10:29:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Philipp Stephani , emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 14 12:29:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9qm6-00022d-2r for ged-emacs-devel@m.gmane.org; Sun, 14 May 2017 12:29:18 +0200 Original-Received: from localhost ([::1]:60390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9qmB-00034I-Ou for ged-emacs-devel@m.gmane.org; Sun, 14 May 2017 06:29:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9qlx-00033n-JY for emacs-devel@gnu.org; Sun, 14 May 2017 06:29:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9qlq-0002lq-Us for emacs-devel@gnu.org; Sun, 14 May 2017 06:29:09 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:55627) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9qlq-0002a6-Mr for emacs-devel@gnu.org; Sun, 14 May 2017 06:29:02 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1d9qlg-0006WA-9D; Sun, 14 May 2017 12:28:54 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEXz7ufAvbjx6+RTUE/3 8uzq5d707+nlJ6JyAAACfElEQVQ4jV1Uy47bMAykhSzvWsN3x61zbjY/YAFanVdB1TMdaPn/n9Ah vekCdQ6xPRo+hkNTWGhZlpfQlMKyBCaiZW2tkd0s6yr32W6INYi9aJQz4ygrC1EQ3rpuFmIFoKK0 aRYNgX+WnDMOOiPn0nMphS6hC542AcOB3t/j85pwDDHbwcjp9ryuCE0cPMf/QMkiAHrGLzW7phhr tZQUVgOMUdb42j5qWxPOlS5hJXXgs05TvYNlQJbvHHud6m2c7udk9ZZHCF9AjQBqrOfdcggodDoY cfpxu6GPwR5Nz6/k6HC8jagqOfCwHB1qpM+1OdAOwESUXrTvCO+RWipF1WVXKN7TMKJrC7WftJtU GFRQzUMdXRDkQABZDJALYiYH4mjJhcPa7ghFXctwNuA6Xq2qchEfFGZHR46bM+x5sXkwxNwPRoy/ U+n6mC3HJhTCsPssavyz+8zhH1IMex7OXlO8vg5EEtxXXPrMaT8ijVNi9GWWI/iCKL0fRcUJoVTp yz6zeqgY38AoXg20KtbRsI6m1OsYk6r7rUH2jcQYAGYHuhxO1HLSAdpWaAvAB2hAx5G8n62mOCFH 5rzNwQBz7o4xgRHHtyS5BMi7OqPv93o9G+PXrloenrxQB+MFfkOO9gGAbXMsFM54gy7XrpSPqk5m kxSfpo7cxSS5U4cd8rY/gR6osHeeGXXxZ2vRHZ/hDsgNw5UZKiIRo6jIqFBgRHOi9oZVySd96VjS Xo7RAvDlNK07tpfxnll4XtztWz4uBDQfeh/HGmzhCaF2LUL/Fid/cxiNzFj0b6AcfxgHzfi4kL9C aMY3RC1IsPMATjrLBW9YLyGgSnybbAvaXyGw9GCW8YWvAAAAAElFTkSuQmCC In-Reply-To: <20170513150837.31184-1-phst@google.com> (Philipp Stephani's message of "Sat, 13 May 2017 17:08:37 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214838 Archived-At: Philipp Stephani writes: > + case AF_INET: > + port = ((struct sockaddr_in6 *) (struct sockaddr *) &sa1)->sin6_port; > + has_port = true; > + break; > + case AF_INET6: > + port = ((struct sockaddr_in *) (struct sockaddr *) &sa1)->sin_port; > + has_port = true; Aren't these two cases in reverse? If it's AF_INET6, it's an in6 struct, not the other way around. Not that it matters, since (as Eli said) the sizes of the first elements in the structs are identical... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no