From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: viper-ex Date: Thu, 13 Jun 2019 14:00:08 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> <8336ke884v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="97139"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 14:00:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbOPL-000P5Y-JW for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 14:00:43 +0200 Original-Received: from localhost ([::1]:38862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOPK-00008O-Ex for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 08:00:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54955) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOOu-0008PT-3P for emacs-devel@gnu.org; Thu, 13 Jun 2019 08:00:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbOOr-0001U0-Lr for emacs-devel@gnu.org; Thu, 13 Jun 2019 08:00:15 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbOOp-0001RZ-N7; Thu, 13 Jun 2019 08:00:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbOOm-00080L-5b; Thu, 13 Jun 2019 14:00:10 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUAAAADAQJ8Wjk9JjAM BwwYEBcnGiSacuBtAAACe0lEQVQ4jVWUTZLbIBCFparJ3qRwDgATHYAe9zoqN9rbptnHCO5/hDyQ PVVBpQ2fXv+3plaVyy4SH85xw6lZkxgzOfcpOFGfzi3Eqrmpilmn2m4GR+TunG+4bC0llXWa5gkH BAoPRR6mxEzjzMZ2U95T99FSfIPJxAzgHFG5gG26HtfTGh/UQeBCBFEyL2BiCR241igQwFsRgx8K xxwca4u3AeyHZFz64QRBcz3AfJ7PKReAYc4zjzy6YpKtAgT2HSHPfQArFpUAIDocEVUA83FOWji3 Eg7gAS4AH8bGTJyRwDdoFc5nlDZmrd+AHOXco5qjany0Qo0AA1w5OkpiVbYnM6FPpedBbjky/1DR 58KobG5dQuHyAlHy03MrGhEbakWuyXQ4uQbXGJVAOgAQpaHIqt73QdCWYYtc8AP8gAkfWo0NfR1R h2WAsyYArpIbsgEpjhNmYYaCob6krRH3FlIH3UeNCyq+oPRUcM9P1waYq/R2uy9FvyHq8Q0wSRzV /kzqPMKixnoofuloq7/YPlpED1I9SuL9IZHQu4TAWu2CKQ+Bo9/u/uyAWqnDx9ktYblT+O0Dhofw vIC5smvk+dmFpTC/FcZmt5Ovr/Glvj4jKmuL+7ovrQP/dn4aintY9KIZQTEyR/Z17I01V9Ud64ZB RXZd8/JxXk38K2m7wlQtcJ/12Bs7G4lp694xKzB0FHE0UVqSPqb1WOkXMMbiWvYtsGBvsdHpvZty O6V407TaqNjpKi9T+HxNK75erWyaUn4DuxrJt1ITAhRd8at4A4t3j1VPPT7e83dUf8bgrcbMxmx8 ue/HH+N9Tj/pjCZurg+c+Y/NsGVtlPgPVLXgwc0Y214AAAAASUVORK5CYII= In-Reply-To: <8336ke884v.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jun 2019 06:41:04 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237498 Archived-At: Eli Zaretskii writes: >> In ex-tag: >> emulation/viper-ex.el:2019:16:Warning: `find-tag' is an obsolete function (as >> of 25.1); use `xref-find-definitions' instead. >> emulation/viper-ex.el:2020:14:Warning: `find-tag-other-window' is an obsolete >> function (as of 25.1); use `xref-find-definitions-other-window' instead. >> >> I thought this was going to be trivial to fix, but: >> >> (if (string= tag "") >> (find-tag ex-tag t) >> (find-tag-other-window ex-tag)) > > Time to use the new anti-warning facilities you just introduced? But presumably this is a real warning about a function that will go away (and the viper-ex function won't), so it should be fixed by rewriting this in terms of the xref-* functions. But I don't know how. :-) There's a handful more of similar calls in the Emacs tree. So what is the proper way to rewrite calls like (find-tag ex-tag t) in terms of the new xref-* machinery? I've Cc'd Dmitry on this now... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no