From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Broken ediff in master (and the bulk lexical scope patches) Date: Thu, 20 Jun 2019 23:13:31 +0200 Message-ID: References: <7no92sc6yi.fsf@ecube.ecubist.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204347"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Barry Fishman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 20 23:19:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1he4Sv-000r3E-Po for ged-emacs-devel@m.gmane.org; Thu, 20 Jun 2019 23:19:29 +0200 Original-Received: from localhost ([::1]:53100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he4Su-0001wq-QV for ged-emacs-devel@m.gmane.org; Thu, 20 Jun 2019 17:19:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52735) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he4Pg-0001uS-PH for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:16:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he4NF-0004Wd-P2 for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:13:39 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:48566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1he4NF-0004Vg-IU for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:13:37 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1he4N9-0002Ri-Si; Thu, 20 Jun 2019 23:13:34 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEXa3N/6/fv+/v7IzdKr s77n6Ov////+//7z8/P+/v38/Pv5+PiXfoPYAAACaElEQVQ4jW2Uz2vTYBjHH5eubO40RBC8jBf6 YnYKJpHZXYbvaw/1EuhSoqfwzj7d6lFUdtucLcFetjGEdBcZrLjmIpuO2fxzvm/TZG+nT1t4nn7y fJ8feRNIR8d4+iSIIr/vB4goCCFxPPgOZzIID2wwmGtbKFAxgeQHfFMAMxMZkIScwnACftmO43Bn gzOHMYfzudUM+A3LtsFiYBgWuGAZr80MNEoSGJZtGbZjGI5tLJpZjdImZ/IjNdRXOk9zwDZUn5QS SlS/0oAqkPTHk3ZamNsUTCO60sMOVS0L8xbIbrlXng5EZjMwrAk6dSXYcze/7P2GRhPxZFgUkeBK 9g62waTMWw0g7gbGuffm64WMTno62GGb3Ob8pYy2erqUCB50g27UV3OUb4G+dmzVdCncDbH9KWu3 qUsd3rs6qnjL+3KC7Rc6eM95iVucyasrZR0cLR8Ej/cfPZTVtmaksMIclzlqtu2ZDPwA3gLAcLKr GYBhe7fd/iidczafLwVQm6Nlr3uucgRBfe2dvbSMK01dagrWDuwmzt8FHbr9vLpYx/BaaWlg57qz zmsudiZaQiueisbSMxl/vttV67rFelVEJTV7fLrDuTAfXejgnee69H8AcSl3hJSiGlgrVoVAhhrw iv/J7D2vFmD64GQBxYUiIdYBinrumKPscc4vvJ8nDBK4/KcGFTLhBv7Ig1+AepFwA2NyNg6RUFWb qAxKBUnSCC5NEh/G0o4JWa0T+bYgxEzSG7iIB+nPNE3Go9HF4JUpeTwYjJRUEkWNwI+k9dOFcZKO 5S9NuxB1AUoA4Hvgg+H7XX9i3l9a6KXh016W5QAAAABJRU5ErkJggg== In-Reply-To: <7no92sc6yi.fsf@ecube.ecubist.org> (Barry Fishman's message of "Thu, 20 Jun 2019 16:55:33 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237989 Archived-At: Barry Fishman writes: > This seem to be due to lisp/vm/ediff.el being compiled with lexical > bindings (explicitly). ediff-files-internal calls ediff-find-file with > its file arguments quoted (as it expects). The lexical stuff in ediff was reverted a few days ago: commit ef23c8be70d2cdc51b7f117ab3b4ad2f16b4ecdc Author: Glenn Morris Date: Tue Jun 18 15:47:49 2019 -0700 Disable lexical-binding in ediff Since it breaks the thing (bug#36157, bug#36281). * lisp/vc/ediff-diff.el, lisp/vc/ediff-help.el, lisp/vc/ediff-hook.el: * lisp/vc/ediff-init.el, lisp/vc/ediff-merg.el, lisp/vc/ediff-mult.el: * lisp/vc/ediff-ptch.el, lisp/vc/ediff-vers.el, lisp/vc/ediff-wind.el: * lisp/vc/ediff.el: Set lexical-binding to nil. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no