From: Lars Ingebrigtsen <larsi@gnus.org>
To: Barry Fishman <barry@ecubist.org>
Cc: emacs-devel@gnu.org
Subject: Re: Broken ediff in master (and the bulk lexical scope patches)
Date: Thu, 20 Jun 2019 23:13:31 +0200 [thread overview]
Message-ID: <m3v9x07yf8.fsf@gnus.org> (raw)
In-Reply-To: <7no92sc6yi.fsf@ecube.ecubist.org> (Barry Fishman's message of "Thu, 20 Jun 2019 16:55:33 -0400")
Barry Fishman <barry@ecubist.org> writes:
> This seem to be due to lisp/vm/ediff.el being compiled with lexical
> bindings (explicitly). ediff-files-internal calls ediff-find-file with
> its file arguments quoted (as it expects).
The lexical stuff in ediff was reverted a few days ago:
commit ef23c8be70d2cdc51b7f117ab3b4ad2f16b4ecdc
Author: Glenn Morris <rgm@gnu.org>
Date: Tue Jun 18 15:47:49 2019 -0700
Disable lexical-binding in ediff
Since it breaks the thing (bug#36157, bug#36281).
* lisp/vc/ediff-diff.el, lisp/vc/ediff-help.el, lisp/vc/ediff-hook.el:
* lisp/vc/ediff-init.el, lisp/vc/ediff-merg.el, lisp/vc/ediff-mult.el:
* lisp/vc/ediff-ptch.el, lisp/vc/ediff-vers.el, lisp/vc/ediff-wind.el:
* lisp/vc/ediff.el: Set lexical-binding to nil.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-06-20 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:55 Broken ediff in master (and the bulk lexical scope patches) Barry Fishman
2019-06-20 21:01 ` Paul Eggert
2019-06-20 21:10 ` Nicolas Semrau
2019-06-20 21:13 ` Lars Ingebrigtsen [this message]
2019-06-20 21:17 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3v9x07yf8.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=barry@ecubist.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).