From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EUDC email addresses via completion-at-point in message-mode Date: Tue, 12 Apr 2022 17:12:30 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 23:13:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neNpi-0004Wx-R6 for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 23:13:54 +0200 Original-Received: from localhost ([::1]:60934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neNph-0003Ts-9F for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 17:13:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neNoV-0002lw-JL for emacs-devel@gnu.org; Tue, 12 Apr 2022 17:12:39 -0400 Original-Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:38648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neNoQ-0006Nk-4b for emacs-devel@gnu.org; Tue, 12 Apr 2022 17:12:39 -0400 Original-Received: by mail-qk1-x72e.google.com with SMTP id 3so7366744qkj.5 for ; Tue, 12 Apr 2022 14:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T+3CG+R8g2WR3l2PgLb8M/7zXwkRGn4eQDLhwayoyCk=; b=OmtmVcoXv4FCKQkpx4Bzdi8JibdEcQKzUhxh9RTTL0ukAOFykY7t30KWCft051ILMr trUqUrOgWx6/43GPjcnaaq5YfEK98b1kUhV8aU/9lVVa+mLgErnDR8waoCmgGB57T4VF KT540BrTx7ZSlTO0/XeDy/0/BZizvRgThRmHgTvXKDnjKUxbNHdixkTtEYf5I4FCbwI3 EBB1+8Z8Gzu57P5FGNhVu+nqyxirhsi3W4+l6EX78RaIRNEhDtOTY/DGg+ChvCav2HnG Bunobug/Atb0AxobtnoqA0GDFmOxTN/zV3DWU9D8n4V4XyhqRMpj2MtIRl1W+Z9hUTOF wDlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T+3CG+R8g2WR3l2PgLb8M/7zXwkRGn4eQDLhwayoyCk=; b=X3WVTjtLOgCLH9md3YyDgF4cMbxyEkV6QKvofA3Kpgv4pkRmJf8PVdSXARqQcpKiS8 KovtnpBUSwX/yKg5ZrNd4kTgum5Ky+vvCtDPs2JSVgx75wCNkROeEkNIDf4iAifmloHX VbSmId5xAvSUhIDZO6cfAmRIFzGZeKtD2JTXoiPJVMPJ/hQX9uGYPLVPaUPOyCgn+f+G cUiDIbkUjndkZ6Uq/4i+iNWTFTBPgiaN5KQVoKQVZevRzKgO2ZaPdK+9E97u3nntbCr1 /ZQBRQKjeeDLLCT4gs5Q8nM6LJOkcp8LbhEQS++mI1eGDY73JqRMZ88sNITLQXznhTN7 S/ew== X-Gm-Message-State: AOAM531E0st5bg/XSVSFcq0UT59Uhp1z95qZFiVI5+64TjEnniBv+HO1 yQxIJIEy+pNLyIlVWBXjR4yzLbOoRfw75w== X-Google-Smtp-Source: ABdhPJw5IpE4E+bOJartrVlR9imwGRRlyntVGoGTgRVCNlcBioikxNxz30mzJF2wXUR102bHWjWmWg== X-Received: by 2002:a37:f511:0:b0:699:d2af:7ac1 with SMTP id l17-20020a37f511000000b00699d2af7ac1mr4549548qkk.221.1649797951699; Tue, 12 Apr 2022 14:12:31 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id v3-20020a05622a014300b002e1dcd4cfa9sm30160393qtw.64.2022.04.12.14.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 14:12:31 -0700 (PDT) In-Reply-To: (Alexander Adolf's message of "Sat, 09 Apr 2022 18:24:02 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=fitzsim@fitzsim.org; helo=mail-qk1-x72e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288342 Archived-At: Hi Alexander, Alexander Adolf writes: > when switching to a new in-buffer completion user interface package > which is solely based on completion-at-point, I observed that email > address completion in message-mode happens in the minibuffer, regardless > of what UI on top of completion-at-point I use. Also, EUDC's ability to > aggregate search results from several servers, which was recently added > with commit 0470a4a939772c4bd25123b15f5eadab41f8bee5, was not kicking > in, i.e. I was presented results from a single EUDC server only. I tested this patch with my current setup, and it doesn't break anything, however I'm not using completion-at-point yet, see below. Is there a way to implement eudc-capf-complete such that it doesn't need eudc-capf-modes? I don't like the fact that eudc-capf-modes would need to be updated every time a new mode wants to use eudc-capf-complete. What would go wrong if you just omitted the mode check? (Maybe I'm missing something about completion-at-point's design here.) Can you add an example in message-mode's manual, for how to make use of completion-at-point, even if it means mentioning a specific completion-at-point UI package? Currently I use: (with-eval-after-load "message" (define-key message-mode-map [(control ?c) (tab)] 'eudc-expand-try-all)) as per the EUDC manual. I shouldn't need that anymore with this patch, correct? What completion-at-point UI package should I install in order to test this? Thanks, Thomas