* including systime.h twice?
@ 2002-02-13 21:41 Pavel Janík
2002-02-14 12:46 ` Richard Stallman
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Janík @ 2002-02-13 21:41 UTC (permalink / raw)
Hi,
in keyboard.c, we include systime.h twice. What about this? I think that
the comment before this is useless now so we can remove it
completely. Right?
--- keyboard.c.~1.655.~ Wed Feb 13 18:08:57 2002
+++ keyboard.c Wed Feb 13 21:55:20 2002
@@ -75,9 +75,6 @@
#include "macterm.h"
#endif
-/* Include systime.h after xterm.h to avoid double inclusion of time.h. */
-#include "systime.h"
-
#ifndef USE_CRT_DLL
extern int errno;
#endif
--
Pavel Janík
So the solution is not build ACPI as a module, because it shouldn't have
allowed you to do so in the first place :)
-- Jeff Garzik in linux-kernel
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: including systime.h twice?
2002-02-13 21:41 including systime.h twice? Pavel Janík
@ 2002-02-14 12:46 ` Richard Stallman
0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2002-02-14 12:46 UTC (permalink / raw)
Cc: emacs-devel
in keyboard.c, we include systime.h twice. What about this? I think that
the comment before this is useless now so we can remove it
completely. Right?
-/* Include systime.h after xterm.h to avoid double inclusion of time.h. */
Indeed, the second #include is a no-op, so deleting it would change
nothing. However, the comment suggests there was once a reason
why it was wrong to do the include any earlier.
I checked xterm.h and it no longer has a way to include time.h.
So I think the comment is obsolete, there is no bug, and your change
is ok.
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-02-14 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-13 21:41 including systime.h twice? Pavel Janík
2002-02-14 12:46 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).