From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: 22 Jan 2004 23:06:16 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <1073937837.2822.180.camel@localhost> <1074519239.10692.24.camel@localhost> <87u12rbrlf.fsf@emptyhost.emptydomain.de> Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ajm89-0005Ie-00 for ; Thu, 22 Jan 2004 22:12:49 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ajm88-00031X-00 for ; Thu, 22 Jan 2004 22:12:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ajm7K-0000oL-U5 for emacs-devel@quimby.gnus.org; Thu, 22 Jan 2004 16:11:58 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Ajm5c-0000NY-M1 for emacs-devel@gnu.org; Thu, 22 Jan 2004 16:10:12 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Ajm25-0007Tb-FA for emacs-devel@gnu.org; Thu, 22 Jan 2004 16:07:04 -0500 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ajm20-0007Sd-KI; Thu, 22 Jan 2004 16:06:28 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id E80B148007D; Thu, 22 Jan 2004 22:06:22 +0100 (CET) Original-To: Stefan Monnier In-Reply-To: Original-Lines: 16 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19432 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19432 Stefan Monnier writes: > >> I suggest to only return narrowed-line-number (i.e. ignore narrowing). > > How about this version? > > By "code that ignores narrowing" I understand code that does not use widen, > narrow, save-restriction, etc... I gave it another round, and by ignoring narrowing as you suggest, the solution is pretty elegant -- both line-at-pos and what-line. I just committed the new code to CVS. This also means that there is now a line-at-pos function which return the current line number. -- Kim F. Storm http://www.cua.dk